UBUNTU-CVE-2024-26921
In the Linux kernel, the following vulnerability has been resolved: inet: inet_defrag: prevent sk release while still in use ip_local_out() and other functions can pass skb->sk as function argument. If the skb is a fragment and reassembly happens before such function call returns, the sk must not be released. This affects skb fragments reassembled via netfilter or similar modules, e.g. openvswitch or ct_act.c, when run as part of tx pipeline. Eric Dumazet made an initial analysis of this bug. Quoting Eric: Calling ip_defrag() in output path is also implying skb_orphan(), which is buggy because output path relies on sk not disappearing. A relevant old patch about the issue was : 8282f27449bf ("inet: frag: Always orphan skbs inside ip_defrag()") [..] net/ipv4/ip_output.c depends on skb->sk being set, and probably to an inet socket, not an arbitrary one. If we orphan the packet in ipvlan, then downstream things like FQ packet scheduler will not work properly. We need to change ip_defrag() to only use skb_orphan() when really needed, ie whenever frag_list is going to be used. Eric suggested to stash sk in fragment queue and made an initial patch. However there is a problem with this: If skb is refragmented again right after, ip_do_fragment() will copy head->sk to the new fragments, and sets up destructor to sock_wfree. IOW, we have no choice but to fix up sk_wmem accouting to reflect the fully reassembled skb, else wmem will underflow. This change moves the orphan down into the core, to last possible moment. As ip_defrag_offset is aliased with sk_buff->sk member, we must move the offset into the FRAG_CB, else skb->sk gets clobbered. This allows to delay the orphaning long enough to learn if the skb has to be queued or if the skb is completing the reasm queue. In the former case, things work as before, skb is orphaned. This is safe because skb gets queued/stolen and won't continue past reasm engine. In the latter case, we will steal the skb->sk reference, reattach it to the head skb, and fix up wmem accouting when inet_frag inflates truesize.
02 / AFFECTED SOFTWARE
Affected packages
12 explicit affected versions
30 explicit affected versions
1 explicit affected versions
150 explicit affected versions
132 explicit affected versions
10 explicit affected versions
8 explicit affected versions
24 explicit affected versions
4 explicit affected versions
7 explicit affected versions
14 explicit affected versions
12 explicit affected versions
10 explicit affected versions
11 explicit affected versions
36 explicit affected versions
6 explicit affected versions
93 explicit affected versions
10 explicit affected versions
34 explicit affected versions
48 explicit affected versions
50 explicit affected versions
6 explicit affected versions
6 explicit affected versions
1 explicit affected versions
12 explicit affected versions
19 explicit affected versions
6 explicit affected versions
57 explicit affected versions
21 explicit affected versions
16 explicit affected versions
10 explicit affected versions
43 explicit affected versions
64 explicit affected versions
53 explicit affected versions
43 explicit affected versions
5 explicit affected versions
50 explicit affected versions
7 explicit affected versions
49 explicit affected versions
1 explicit affected versions
91 explicit affected versions
13 explicit affected versions
67 explicit affected versions
2 explicit affected versions
35 explicit affected versions
10 explicit affected versions
16 explicit affected versions
18 explicit affected versions
11 explicit affected versions
98 explicit affected versions
13 explicit affected versions
4 explicit affected versions
23 explicit affected versions
106 explicit affected versions
9 explicit affected versions
10 explicit affected versions
48 explicit affected versions
7 explicit affected versions
7 explicit affected versions
12 explicit affected versions
41 explicit affected versions
12 explicit affected versions
14 explicit affected versions
7 explicit affected versions
81 explicit affected versions
11 explicit affected versions
96 explicit affected versions
104 explicit affected versions
12 explicit affected versions
92 explicit affected versions
105 explicit affected versions
13 explicit affected versions
2 explicit affected versions
10 explicit affected versions
173 explicit affected versions
37 explicit affected versions
13 explicit affected versions
34 explicit affected versions
26 explicit affected versions
13 explicit affected versions
6 explicit affected versions
26 explicit affected versions
1 explicit affected versions
29 explicit affected versions
84 explicit affected versions
13 explicit affected versions
96 explicit affected versions
54 explicit affected versions
1 explicit affected versions
79 explicit affected versions
52 explicit affected versions
33 explicit affected versions
23 explicit affected versions
10 explicit affected versions
96 explicit affected versions
11 explicit affected versions
119 explicit affected versions
7 explicit affected versions
12 explicit affected versions
94 explicit affected versions
2 explicit affected versions
41 explicit affected versions
35 explicit affected versions
112 explicit affected versions
51 explicit affected versions
26 explicit affected versions
8 explicit affected versions
30 explicit affected versions
1 explicit affected versions
13 explicit affected versions
7 explicit affected versions
119 explicit affected versions
54 explicit affected versions
16 explicit affected versions
54 explicit affected versions
8 explicit affected versions
42 explicit affected versions
3 explicit affected versions
1 explicit affected versions
73 explicit affected versions
1 explicit affected versions
2 explicit affected versions
61 explicit affected versions
8 explicit affected versions
51 explicit affected versions
72 explicit affected versions
5 explicit affected versions
12 explicit affected versions
40 explicit affected versions
27 explicit affected versions
26 explicit affected versions
1 explicit affected versions
1 explicit affected versions
76 explicit affected versions
15 explicit affected versions
5 explicit affected versions
2 explicit affected versions
8 explicit affected versions
1 explicit affected versions
4 explicit affected versions
13 explicit affected versions
83 explicit affected versions
13 explicit affected versions
12 explicit affected versions
48 explicit affected versions
7 explicit affected versions
74 explicit affected versions
45 explicit affected versions
10 explicit affected versions
83 explicit affected versions
44 explicit affected versions
16 explicit affected versions
3 explicit affected versions
13 explicit affected versions
40 explicit affected versions
37 explicit affected versions
8 explicit affected versions
14 explicit affected versions
51 explicit affected versions
38 explicit affected versions
43 explicit affected versions
9 explicit affected versions
43 explicit affected versions
11 explicit affected versions
83 explicit affected versions
55 explicit affected versions
123 explicit affected versions
102 explicit affected versions
1 explicit affected versions
1 explicit affected versions
49 explicit affected versions
95 explicit affected versions
13 explicit affected versions
43 explicit affected versions
49 explicit affected versions
129 explicit affected versions
146 explicit affected versions
10 explicit affected versions
8 explicit affected versions
3 explicit affected versions
14 explicit affected versions
84 explicit affected versions
4 explicit affected versions
73 explicit affected versions
11 explicit affected versions
1 explicit affected versions
49 explicit affected versions
2 explicit affected versions
03 / CONNECTIONS
Connected vulnerabilities
04 / EVIDENCE
Source records
In the Linux kernel, the following vulnerability has been resolved: inet: inet_defrag: prevent sk release while still in use ip_local_out() and other functions can pass skb->sk as function argument. If the skb is a fragment and reassembly happens before such function call returns, the sk must not be released. This affects skb fragments reassembled via netfilter or similar modules, e.g. openvswitch or ct_act.c, when run as part of tx pipeline. Eric Dumazet made an initial analysis of this bug. Quoting Eric: Calling ip_defrag() in output path is also implying skb_orphan(), which is buggy because output path relies on sk not disappearing. A relevant old patch about the issue was : 8282f27449bf ("inet: frag: Always orphan skbs inside ip_defrag()") [..] net/ipv4/ip_output.c depends on skb->sk being set, and probably to an inet socket, not an arbitrary one. If we orphan the packet in ipvlan, then downstream things like FQ packet scheduler will not work properly. We need to change ip_defrag() to only use skb_orphan() when really needed, ie whenever frag_list is going to be used. Eric suggested to stash sk in fragment queue and made an initial patch. However there is a problem with this: If skb is refragmented again right after, ip_do_fragment() will copy head->sk to the new fragments, and sets up destructor to sock_wfree. IOW, we have no choice but to fix up sk_wmem accouting to reflect the fully reassembled skb, else wmem will underflow. This change moves the orphan down into the core, to last possible moment. As ip_defrag_offset is aliased with sk_buff->sk member, we must move the offset into the FRAG_CB, else skb->sk gets clobbered. This allows to delay the orphaning long enough to learn if the skb has to be queued or if the skb is completing the reasm queue. In the former case, things work as before, skb is orphaned. This is safe because skb gets queued/stolen and won't continue past reasm engine. In the latter case, we will steal the skb->sk reference, reattach it to the head skb, and fix up wmem accouting when inet_frag inflates truesize.
05 / REFERENCES
Further evidence
- https://git.kernel.org/linus/18685451fc4e546fc0e718580d32df3c0e5c8272
- https://git.kernel.org/stable/c/18685451fc4e546fc0e718580d32df3c0e5c8272
- https://git.kernel.org/stable/c/7d0567842b78390dd9b60f00f1d8f838d540e325
- https://git.kernel.org/stable/c/e09cbe017311508c21e0739e97198a8388b98981
- https://git.kernel.org/stable/c/f4877225313d474659ee53150ccc3d553a978727
- https://ubuntu.com/security/CVE-2024-26921
- https://ubuntu.com/security/notices/USN-6893-1
- https://ubuntu.com/security/notices/USN-6893-2
- https://ubuntu.com/security/notices/USN-6893-3
- https://ubuntu.com/security/notices/USN-6918-1
- https://ubuntu.com/security/notices/USN-6973-1
- https://ubuntu.com/security/notices/USN-6973-2
- https://ubuntu.com/security/notices/USN-6973-3
- https://ubuntu.com/security/notices/USN-6973-4
- https://ubuntu.com/security/notices/USN-6974-1
- https://ubuntu.com/security/notices/USN-6974-2
- https://ubuntu.com/security/notices/USN-7006-1
- https://ubuntu.com/security/notices/USN-7019-1
- https://ubuntu.com/security/notices/USN-7185-1
- https://ubuntu.com/security/notices/USN-7185-2
- https://ubuntu.com/security/notices/USN-7429-1
- https://ubuntu.com/security/notices/USN-7429-2
- https://www.cve.org/CVERecord?id=CVE-2024-26921