UBUNTU-CVE-2024-26924
In the Linux kernel, the following vulnerability has been resolved: netfilter: nft_set_pipapo: do not free live element Pablo reports a crash with large batches of elements with a back-to-back add/remove pattern. Quoting Pablo: add_elem("00000000") timeout 100 ms ... add_elem("0000000X") timeout 100 ms del_elem("0000000X") <---------------- delete one that was just added ... add_elem("00005000") timeout 100 ms 1) nft_pipapo_remove() removes element 0000000X Then, KASAN shows a splat. Looking at the remove function there is a chance that we will drop a rule that maps to a non-deactivated element. Removal happens in two steps, first we do a lookup for key k and return the to-be-removed element and mark it as inactive in the next generation. Then, in a second step, the element gets removed from the set/map. The _remove function does not work correctly if we have more than one element that share the same key. This can happen if we insert an element into a set when the set already holds an element with same key, but the element mapping to the existing key has timed out or is not active in the next generation. In such case its possible that removal will unmap the wrong element. If this happens, we will leak the non-deactivated element, it becomes unreachable. The element that got deactivated (and will be freed later) will remain reachable in the set data structure, this can result in a crash when such an element is retrieved during lookup (stale pointer). Add a check that the fully matching key does in fact map to the element that we have marked as inactive in the deactivation step. If not, we need to continue searching. Add a bug/warn trap at the end of the function as well, the remove function must not ever be called with an invisible/unreachable/non-existent element. v2: avoid uneeded temporary variable (Stefano)
02 / AFFECTED SOFTWARE
Affected packages
6 explicit affected versions
7 explicit affected versions
12 explicit affected versions
12 explicit affected versions
26 explicit affected versions
8 explicit affected versions
30 explicit affected versions
44 explicit affected versions
50 explicit affected versions
11 explicit affected versions
12 explicit affected versions
17 explicit affected versions
6 explicit affected versions
53 explicit affected versions
5 explicit affected versions
39 explicit affected versions
50 explicit affected versions
39 explicit affected versions
8 explicit affected versions
10 explicit affected versions
4 explicit affected versions
46 explicit affected versions
7 explicit affected versions
46 explicit affected versions
1 explicit affected versions
10 explicit affected versions
1 explicit affected versions
35 explicit affected versions
6 explicit affected versions
14 explicit affected versions
18 explicit affected versions
8 explicit affected versions
33 explicit affected versions
6 explicit affected versions
13 explicit affected versions
4 explicit affected versions
23 explicit affected versions
8 explicit affected versions
21 explicit affected versions
16 explicit affected versions
10 explicit affected versions
6 explicit affected versions
37 explicit affected versions
12 explicit affected versions
11 explicit affected versions
7 explicit affected versions
12 explicit affected versions
10 explicit affected versions
1 explicit affected versions
37 explicit affected versions
10 explicit affected versions
10 explicit affected versions
26 explicit affected versions
13 explicit affected versions
5 explicit affected versions
29 explicit affected versions
7 explicit affected versions
13 explicit affected versions
50 explicit affected versions
48 explicit affected versions
10 explicit affected versions
33 explicit affected versions
23 explicit affected versions
10 explicit affected versions
11 explicit affected versions
12 explicit affected versions
8 explicit affected versions
7 explicit affected versions
12 explicit affected versions
38 explicit affected versions
31 explicit affected versions
47 explicit affected versions
26 explicit affected versions
7 explicit affected versions
1 explicit affected versions
7 explicit affected versions
13 explicit affected versions
6 explicit affected versions
16 explicit affected versions
50 explicit affected versions
40 explicit affected versions
3 explicit affected versions
2 explicit affected versions
51 explicit affected versions
4 explicit affected versions
12 explicit affected versions
36 explicit affected versions
27 explicit affected versions
22 explicit affected versions
11 explicit affected versions
5 explicit affected versions
1 explicit affected versions
8 explicit affected versions
10 explicit affected versions
3 explicit affected versions
10 explicit affected versions
13 explicit affected versions
7 explicit affected versions
44 explicit affected versions
42 explicit affected versions
10 explicit affected versions
12 explicit affected versions
12 explicit affected versions
80 explicit affected versions
16 explicit affected versions
3 explicit affected versions
13 explicit affected versions
26 explicit affected versions
36 explicit affected versions
37 explicit affected versions
7 explicit affected versions
11 explicit affected versions
38 explicit affected versions
7 explicit affected versions
39 explicit affected versions
9 explicit affected versions
39 explicit affected versions
11 explicit affected versions
47 explicit affected versions
20 explicit affected versions
4 explicit affected versions
1 explicit affected versions
1 explicit affected versions
45 explicit affected versions
43 explicit affected versions
10 explicit affected versions
8 explicit affected versions
2 explicit affected versions
14 explicit affected versions
4 explicit affected versions
8 explicit affected versions
1 explicit affected versions
1 explicit affected versions
03 / CONNECTIONS
Connected vulnerabilities
04 / EVIDENCE
Source records
In the Linux kernel, the following vulnerability has been resolved: netfilter: nft_set_pipapo: do not free live element Pablo reports a crash with large batches of elements with a back-to-back add/remove pattern. Quoting Pablo: add_elem("00000000") timeout 100 ms ... add_elem("0000000X") timeout 100 ms del_elem("0000000X") <---------------- delete one that was just added ... add_elem("00005000") timeout 100 ms 1) nft_pipapo_remove() removes element 0000000X Then, KASAN shows a splat. Looking at the remove function there is a chance that we will drop a rule that maps to a non-deactivated element. Removal happens in two steps, first we do a lookup for key k and return the to-be-removed element and mark it as inactive in the next generation. Then, in a second step, the element gets removed from the set/map. The _remove function does not work correctly if we have more than one element that share the same key. This can happen if we insert an element into a set when the set already holds an element with same key, but the element mapping to the existing key has timed out or is not active in the next generation. In such case its possible that removal will unmap the wrong element. If this happens, we will leak the non-deactivated element, it becomes unreachable. The element that got deactivated (and will be freed later) will remain reachable in the set data structure, this can result in a crash when such an element is retrieved during lookup (stale pointer). Add a check that the fully matching key does in fact map to the element that we have marked as inactive in the deactivation step. If not, we need to continue searching. Add a bug/warn trap at the end of the function as well, the remove function must not ever be called with an invisible/unreachable/non-existent element. v2: avoid uneeded temporary variable (Stefano)
05 / REFERENCES
Further evidence
- https://git.kernel.org/linus/3cfc9ec039af60dbd8965ae085b2c2ccdcfbe1cc
- https://git.kernel.org/stable/c/3cfc9ec039af60dbd8965ae085b2c2ccdcfbe1cc
- https://ubuntu.com/security/CVE-2024-26924
- https://ubuntu.com/security/notices/USN-6863-1
- https://ubuntu.com/security/notices/USN-6864-1
- https://ubuntu.com/security/notices/USN-6864-2
- https://ubuntu.com/security/notices/USN-6864-3
- https://ubuntu.com/security/notices/USN-6869-1
- https://ubuntu.com/security/notices/USN-6870-1
- https://ubuntu.com/security/notices/USN-6870-2
- https://ubuntu.com/security/notices/USN-6871-1
- https://ubuntu.com/security/notices/USN-6872-1
- https://ubuntu.com/security/notices/USN-6872-2
- https://ubuntu.com/security/notices/USN-6873-1
- https://ubuntu.com/security/notices/USN-6873-2
- https://ubuntu.com/security/notices/USN-6874-1
- https://ubuntu.com/security/notices/USN-6875-1
- https://ubuntu.com/security/notices/USN-6892-1
- https://ubuntu.com/security/notices/USN-6900-1
- https://ubuntu.com/security/notices/USN-6918-1
- https://ubuntu.com/security/notices/USN-6919-1
- https://ubuntu.com/security/notices/USN-6927-1
- https://www.cve.org/CVERecord?id=CVE-2024-26924