UBUNTU-CVE-2024-27012
In the Linux kernel, the following vulnerability has been resolved: netfilter: nf_tables: restore set elements when delete set fails From abort path, nft_mapelem_activate() needs to restore refcounters to the original state. Currently, it uses the set->ops->walk() to iterate over these set elements. The existing set iterator skips inactive elements in the next generation, this does not work from the abort path to restore the original state since it has to skip active elements instead (not inactive ones). This patch moves the check for inactive elements to the set iterator callback, then it reverses the logic for the .activate case which needs to skip active elements. Toggle next generation bit for elements when delete set command is invoked and call nft_clear() from .activate (abort) path to restore the next generation bit. The splat below shows an object in mappings memleak: [43929.457523] ------------[ cut here ]------------ [43929.457532] WARNING: CPU: 0 PID: 1139 at include/net/netfilter/nf_tables.h:1237 nft_setelem_data_deactivate+0xe4/0xf0 [nf_tables] [...] [43929.458014] RIP: 0010:nft_setelem_data_deactivate+0xe4/0xf0 [nf_tables] [43929.458076] Code: 83 f8 01 77 ab 49 8d 7c 24 08 e8 37 5e d0 de 49 8b 6c 24 08 48 8d 7d 50 e8 e9 5c d0 de 8b 45 50 8d 50 ff 89 55 50 85 c0 75 86 <0f> 0b eb 82 0f 0b eb b3 0f 1f 40 00 90 90 90 90 90 90 90 90 90 90 [43929.458081] RSP: 0018:ffff888140f9f4b0 EFLAGS: 00010246 [43929.458086] RAX: 0000000000000000 RBX: ffff8881434f5288 RCX: dffffc0000000000 [43929.458090] RDX: 00000000ffffffff RSI: ffffffffa26d28a7 RDI: ffff88810ecc9550 [43929.458093] RBP: ffff88810ecc9500 R08: 0000000000000001 R09: ffffed10281f3e8f [43929.458096] R10: 0000000000000003 R11: ffff0000ffff0000 R12: ffff8881434f52a0 [43929.458100] R13: ffff888140f9f5f4 R14: ffff888151c7a800 R15: 0000000000000002 [43929.458103] FS: 00007f0c687c4740(0000) GS:ffff888390800000(0000) knlGS:0000000000000000 [43929.458107] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 [43929.458111] CR2: 00007f58dbe5b008 CR3: 0000000123602005 CR4: 00000000001706f0 [43929.458114] Call Trace: [43929.458118] <TASK> [43929.458121] ? __warn+0x9f/0x1a0 [43929.458127] ? nft_setelem_data_deactivate+0xe4/0xf0 [nf_tables] [43929.458188] ? report_bug+0x1b1/0x1e0 [43929.458196] ? handle_bug+0x3c/0x70 [43929.458200] ? exc_invalid_op+0x17/0x40 [43929.458211] ? nft_setelem_data_deactivate+0xd7/0xf0 [nf_tables] [43929.458271] ? nft_setelem_data_deactivate+0xe4/0xf0 [nf_tables] [43929.458332] nft_mapelem_deactivate+0x24/0x30 [nf_tables] [43929.458392] nft_rhash_walk+0xdd/0x180 [nf_tables] [43929.458453] ? __pfx_nft_rhash_walk+0x10/0x10 [nf_tables] [43929.458512] ? rb_insert_color+0x2e/0x280 [43929.458520] nft_map_deactivate+0xdc/0x1e0 [nf_tables] [43929.458582] ? __pfx_nft_map_deactivate+0x10/0x10 [nf_tables] [43929.458642] ? __pfx_nft_mapelem_deactivate+0x10/0x10 [nf_tables] [43929.458701] ? __rcu_read_unlock+0x46/0x70 [43929.458709] nft_delset+0xff/0x110 [nf_tables] [43929.458769] nft_flush_table+0x16f/0x460 [nf_tables] [43929.458830] nf_tables_deltable+0x501/0x580 [nf_tables]
02 / AFFECTED SOFTWARE
Affected packages
11 explicit affected versions
36 explicit affected versions
50 explicit affected versions
50 explicit affected versions
6 explicit affected versions
12 explicit affected versions
19 explicit affected versions
6 explicit affected versions
59 explicit affected versions
6 explicit affected versions
45 explicit affected versions
66 explicit affected versions
55 explicit affected versions
45 explicit affected versions
10 explicit affected versions
5 explicit affected versions
52 explicit affected versions
7 explicit affected versions
51 explicit affected versions
1 explicit affected versions
93 explicit affected versions
13 explicit affected versions
2 explicit affected versions
35 explicit affected versions
12 explicit affected versions
17 explicit affected versions
18 explicit affected versions
13 explicit affected versions
38 explicit affected versions
6 explicit affected versions
95 explicit affected versions
13 explicit affected versions
4 explicit affected versions
23 explicit affected versions
9 explicit affected versions
21 explicit affected versions
16 explicit affected versions
10 explicit affected versions
50 explicit affected versions
7 explicit affected versions
7 explicit affected versions
12 explicit affected versions
43 explicit affected versions
12 explicit affected versions
14 explicit affected versions
7 explicit affected versions
83 explicit affected versions
12 explicit affected versions
98 explicit affected versions
106 explicit affected versions
12 explicit affected versions
94 explicit affected versions
13 explicit affected versions
2 explicit affected versions
37 explicit affected versions
13 explicit affected versions
10 explicit affected versions
31 explicit affected versions
35 explicit affected versions
26 explicit affected versions
13 explicit affected versions
7 explicit affected versions
29 explicit affected versions
86 explicit affected versions
13 explicit affected versions
56 explicit affected versions
81 explicit affected versions
54 explicit affected versions
98 explicit affected versions
16 explicit affected versions
33 explicit affected versions
23 explicit affected versions
10 explicit affected versions
11 explicit affected versions
12 explicit affected versions
7 explicit affected versions
12 explicit affected versions
96 explicit affected versions
43 explicit affected versions
37 explicit affected versions
53 explicit affected versions
10 explicit affected versions
26 explicit affected versions
8 explicit affected versions
32 explicit affected versions
1 explicit affected versions
8 explicit affected versions
13 explicit affected versions
7 explicit affected versions
56 explicit affected versions
16 explicit affected versions
56 explicit affected versions
8 explicit affected versions
44 explicit affected versions
3 explicit affected versions
2 explicit affected versions
63 explicit affected versions
51 explicit affected versions
5 explicit affected versions
12 explicit affected versions
42 explicit affected versions
27 explicit affected versions
28 explicit affected versions
1 explicit affected versions
8 explicit affected versions
17 explicit affected versions
5 explicit affected versions
2 explicit affected versions
8 explicit affected versions
10 explicit affected versions
4 explicit affected versions
13 explicit affected versions
85 explicit affected versions
13 explicit affected versions
50 explicit affected versions
7 explicit affected versions
47 explicit affected versions
10 explicit affected versions
13 explicit affected versions
12 explicit affected versions
85 explicit affected versions
44 explicit affected versions
16 explicit affected versions
3 explicit affected versions
13 explicit affected versions
26 explicit affected versions
42 explicit affected versions
37 explicit affected versions
8 explicit affected versions
14 explicit affected versions
38 explicit affected versions
45 explicit affected versions
9 explicit affected versions
45 explicit affected versions
11 explicit affected versions
53 explicit affected versions
7 explicit affected versions
26 explicit affected versions
57 explicit affected versions
4 explicit affected versions
1 explicit affected versions
51 explicit affected versions
13 explicit affected versions
43 explicit affected versions
51 explicit affected versions
10 explicit affected versions
8 explicit affected versions
3 explicit affected versions
14 explicit affected versions
86 explicit affected versions
4 explicit affected versions
75 explicit affected versions
11 explicit affected versions
1 explicit affected versions
2 explicit affected versions
03 / CONNECTIONS
Connected vulnerabilities
04 / EVIDENCE
Source records
In the Linux kernel, the following vulnerability has been resolved: netfilter: nf_tables: restore set elements when delete set fails From abort path, nft_mapelem_activate() needs to restore refcounters to the original state. Currently, it uses the set->ops->walk() to iterate over these set elements. The existing set iterator skips inactive elements in the next generation, this does not work from the abort path to restore the original state since it has to skip active elements instead (not inactive ones). This patch moves the check for inactive elements to the set iterator callback, then it reverses the logic for the .activate case which needs to skip active elements. Toggle next generation bit for elements when delete set command is invoked and call nft_clear() from .activate (abort) path to restore the next generation bit. The splat below shows an object in mappings memleak: [43929.457523] ------------[ cut here ]------------ [43929.457532] WARNING: CPU: 0 PID: 1139 at include/net/netfilter/nf_tables.h:1237 nft_setelem_data_deactivate+0xe4/0xf0 [nf_tables] [...] [43929.458014] RIP: 0010:nft_setelem_data_deactivate+0xe4/0xf0 [nf_tables] [43929.458076] Code: 83 f8 01 77 ab 49 8d 7c 24 08 e8 37 5e d0 de 49 8b 6c 24 08 48 8d 7d 50 e8 e9 5c d0 de 8b 45 50 8d 50 ff 89 55 50 85 c0 75 86 <0f> 0b eb 82 0f 0b eb b3 0f 1f 40 00 90 90 90 90 90 90 90 90 90 90 [43929.458081] RSP: 0018:ffff888140f9f4b0 EFLAGS: 00010246 [43929.458086] RAX: 0000000000000000 RBX: ffff8881434f5288 RCX: dffffc0000000000 [43929.458090] RDX: 00000000ffffffff RSI: ffffffffa26d28a7 RDI: ffff88810ecc9550 [43929.458093] RBP: ffff88810ecc9500 R08: 0000000000000001 R09: ffffed10281f3e8f [43929.458096] R10: 0000000000000003 R11: ffff0000ffff0000 R12: ffff8881434f52a0 [43929.458100] R13: ffff888140f9f5f4 R14: ffff888151c7a800 R15: 0000000000000002 [43929.458103] FS: 00007f0c687c4740(0000) GS:ffff888390800000(0000) knlGS:0000000000000000 [43929.458107] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 [43929.458111] CR2: 00007f58dbe5b008 CR3: 0000000123602005 CR4: 00000000001706f0 [43929.458114] Call Trace: [43929.458118] <TASK> [43929.458121] ? __warn+0x9f/0x1a0 [43929.458127] ? nft_setelem_data_deactivate+0xe4/0xf0 [nf_tables] [43929.458188] ? report_bug+0x1b1/0x1e0 [43929.458196] ? handle_bug+0x3c/0x70 [43929.458200] ? exc_invalid_op+0x17/0x40 [43929.458211] ? nft_setelem_data_deactivate+0xd7/0xf0 [nf_tables] [43929.458271] ? nft_setelem_data_deactivate+0xe4/0xf0 [nf_tables] [43929.458332] nft_mapelem_deactivate+0x24/0x30 [nf_tables] [43929.458392] nft_rhash_walk+0xdd/0x180 [nf_tables] [43929.458453] ? __pfx_nft_rhash_walk+0x10/0x10 [nf_tables] [43929.458512] ? rb_insert_color+0x2e/0x280 [43929.458520] nft_map_deactivate+0xdc/0x1e0 [nf_tables] [43929.458582] ? __pfx_nft_map_deactivate+0x10/0x10 [nf_tables] [43929.458642] ? __pfx_nft_mapelem_deactivate+0x10/0x10 [nf_tables] [43929.458701] ? __rcu_read_unlock+0x46/0x70 [43929.458709] nft_delset+0xff/0x110 [nf_tables] [43929.458769] nft_flush_table+0x16f/0x460 [nf_tables] [43929.458830] nf_tables_deltable+0x501/0x580 [nf_tables]
05 / REFERENCES
Further evidence
- https://git.kernel.org/linus/e79b47a8615d42c68aaeb68971593333667382ed
- https://git.kernel.org/stable/c/86658fc7414d4b9e25c2699d751034537503d637
- https://git.kernel.org/stable/c/e79b47a8615d42c68aaeb68971593333667382ed
- https://ubuntu.com/security/CVE-2024-27012
- https://ubuntu.com/security/notices/USN-6893-1
- https://ubuntu.com/security/notices/USN-6893-2
- https://ubuntu.com/security/notices/USN-6893-3
- https://ubuntu.com/security/notices/USN-6918-1
- https://ubuntu.com/security/notices/USN-7021-1
- https://ubuntu.com/security/notices/USN-7021-2
- https://ubuntu.com/security/notices/USN-7021-3
- https://ubuntu.com/security/notices/USN-7021-4
- https://ubuntu.com/security/notices/USN-7021-5
- https://ubuntu.com/security/notices/USN-7022-1
- https://ubuntu.com/security/notices/USN-7022-2
- https://ubuntu.com/security/notices/USN-7022-3
- https://ubuntu.com/security/notices/USN-7119-1
- https://www.cve.org/CVERecord?id=CVE-2024-27012