UBUNTU-CVE-2024-35960
In the Linux kernel, the following vulnerability has been resolved: net/mlx5: Properly link new fs rules into the tree Previously, add_rule_fg would only add newly created rules from the handle into the tree when they had a refcount of 1. On the other hand, create_flow_handle tries hard to find and reference already existing identical rules instead of creating new ones. These two behaviors can result in a situation where create_flow_handle 1) creates a new rule and references it, then 2) in a subsequent step during the same handle creation references it again, resulting in a rule with a refcount of 2 that is not linked into the tree, will have a NULL parent and root and will result in a crash when the flow group is deleted because del_sw_hw_rule, invoked on rule deletion, assumes node->parent is != NULL. This happened in the wild, due to another bug related to incorrect handling of duplicate pkt_reformat ids, which lead to the code in create_flow_handle incorrectly referencing a just-added rule in the same flow handle, resulting in the problem described above. Full details are at [1]. This patch changes add_rule_fg to add new rules without parents into the tree, properly initializing them and avoiding the crash. This makes it more consistent with how rules are added to an FTE in create_flow_handle.
02 / AFFECTED SOFTWARE
Affected packages
8 explicit affected versions
80 explicit affected versions
1 explicit affected versions
8 explicit affected versions
80 explicit affected versions
4 explicit affected versions
1 explicit affected versions
1 explicit affected versions
11 explicit affected versions
31 explicit affected versions
47 explicit affected versions
93 explicit affected versions
70 explicit affected versions
2 explicit affected versions
90 explicit affected versions
16 explicit affected versions
10 explicit affected versions
45 explicit affected versions
50 explicit affected versions
6 explicit affected versions
12 explicit affected versions
61 explicit affected versions
19 explicit affected versions
6 explicit affected versions
54 explicit affected versions
6 explicit affected versions
40 explicit affected versions
51 explicit affected versions
40 explicit affected versions
10 explicit affected versions
5 explicit affected versions
7 explicit affected versions
46 explicit affected versions
1 explicit affected versions
88 explicit affected versions
13 explicit affected versions
35 explicit affected versions
7 explicit affected versions
14 explicit affected versions
18 explicit affected versions
12 explicit affected versions
9 explicit affected versions
101 explicit affected versions
34 explicit affected versions
6 explicit affected versions
13 explicit affected versions
4 explicit affected versions
23 explicit affected versions
9 explicit affected versions
1 explicit affected versions
21 explicit affected versions
45 explicit affected versions
7 explicit affected versions
7 explicit affected versions
12 explicit affected versions
38 explicit affected versions
14 explicit affected versions
7 explicit affected versions
78 explicit affected versions
12 explicit affected versions
1 explicit affected versions
93 explicit affected versions
101 explicit affected versions
12 explicit affected versions
89 explicit affected versions
10 explicit affected versions
2 explicit affected versions
10 explicit affected versions
37 explicit affected versions
13 explicit affected versions
10 explicit affected versions
27 explicit affected versions
31 explicit affected versions
26 explicit affected versions
13 explicit affected versions
6 explicit affected versions
1 explicit affected versions
29 explicit affected versions
81 explicit affected versions
13 explicit affected versions
51 explicit affected versions
1 explicit affected versions
77 explicit affected versions
49 explicit affected versions
11 explicit affected versions
33 explicit affected versions
23 explicit affected versions
10 explicit affected versions
99 explicit affected versions
11 explicit affected versions
12 explicit affected versions
122 explicit affected versions
32 explicit affected versions
7 explicit affected versions
12 explicit affected versions
92 explicit affected versions
39 explicit affected versions
8 explicit affected versions
115 explicit affected versions
48 explicit affected versions
136 explicit affected versions
10 explicit affected versions
26 explicit affected versions
27 explicit affected versions
1 explicit affected versions
8 explicit affected versions
13 explicit affected versions
7 explicit affected versions
122 explicit affected versions
51 explicit affected versions
16 explicit affected versions
51 explicit affected versions
40 explicit affected versions
3 explicit affected versions
76 explicit affected versions
1 explicit affected versions
2 explicit affected versions
58 explicit affected versions
51 explicit affected versions
75 explicit affected versions
5 explicit affected versions
12 explicit affected versions
37 explicit affected versions
27 explicit affected versions
23 explicit affected versions
1 explicit affected versions
1 explicit affected versions
10 explicit affected versions
4 explicit affected versions
13 explicit affected versions
12 explicit affected versions
5 explicit affected versions
2 explicit affected versions
8 explicit affected versions
1 explicit affected versions
81 explicit affected versions
13 explicit affected versions
45 explicit affected versions
7 explicit affected versions
7 explicit affected versions
77 explicit affected versions
43 explicit affected versions
10 explicit affected versions
12 explicit affected versions
12 explicit affected versions
44 explicit affected versions
16 explicit affected versions
3 explicit affected versions
13 explicit affected versions
26 explicit affected versions
37 explicit affected versions
37 explicit affected versions
8 explicit affected versions
14 explicit affected versions
38 explicit affected versions
40 explicit affected versions
9 explicit affected versions
40 explicit affected versions
11 explicit affected versions
48 explicit affected versions
21 explicit affected versions
52 explicit affected versions
126 explicit affected versions
105 explicit affected versions
150 explicit affected versions
46 explicit affected versions
98 explicit affected versions
13 explicit affected versions
43 explicit affected versions
46 explicit affected versions
10 explicit affected versions
8 explicit affected versions
3 explicit affected versions
14 explicit affected versions
81 explicit affected versions
4 explicit affected versions
70 explicit affected versions
11 explicit affected versions
1 explicit affected versions
52 explicit affected versions
2 explicit affected versions
03 / CONNECTIONS
Connected vulnerabilities
04 / EVIDENCE
Source records
In the Linux kernel, the following vulnerability has been resolved: net/mlx5: Properly link new fs rules into the tree Previously, add_rule_fg would only add newly created rules from the handle into the tree when they had a refcount of 1. On the other hand, create_flow_handle tries hard to find and reference already existing identical rules instead of creating new ones. These two behaviors can result in a situation where create_flow_handle 1) creates a new rule and references it, then 2) in a subsequent step during the same handle creation references it again, resulting in a rule with a refcount of 2 that is not linked into the tree, will have a NULL parent and root and will result in a crash when the flow group is deleted because del_sw_hw_rule, invoked on rule deletion, assumes node->parent is != NULL. This happened in the wild, due to another bug related to incorrect handling of duplicate pkt_reformat ids, which lead to the code in create_flow_handle incorrectly referencing a just-added rule in the same flow handle, resulting in the problem described above. Full details are at [1]. This patch changes add_rule_fg to add new rules without parents into the tree, properly initializing them and avoiding the crash. This makes it more consistent with how rules are added to an FTE in create_flow_handle.
05 / REFERENCES
Further evidence
- https://git.kernel.org/linus/7c6782ad4911cbee874e85630226ed389ff2e453
- https://git.kernel.org/stable/c/1263b0b26077b1183c3c45a0a2479573a351d423
- https://git.kernel.org/stable/c/2e8dc5cffc844dacfa79f056dea88002312f253f
- https://git.kernel.org/stable/c/3d90ca9145f6b97b38d0c2b6b30f6ca6af9c1801
- https://git.kernel.org/stable/c/5cf5337ef701830f173b4eec00a4f984adeb57a0
- https://git.kernel.org/stable/c/7aaee12b804c5e0374e7b132b6ec2158ff33dd64
- https://git.kernel.org/stable/c/7c6782ad4911cbee874e85630226ed389ff2e453
- https://git.kernel.org/stable/c/adf67a03af39095f05d82050f15813d6f700159d
- https://git.kernel.org/stable/c/de0139719cdda82806a47580ca0df06fc85e0bd2
- https://ubuntu.com/security/CVE-2024-35960
- https://ubuntu.com/security/notices/USN-6893-1
- https://ubuntu.com/security/notices/USN-6893-2
- https://ubuntu.com/security/notices/USN-6893-3
- https://ubuntu.com/security/notices/USN-6896-1
- https://ubuntu.com/security/notices/USN-6896-2
- https://ubuntu.com/security/notices/USN-6896-3
- https://ubuntu.com/security/notices/USN-6896-4
- https://ubuntu.com/security/notices/USN-6896-5
- https://ubuntu.com/security/notices/USN-6898-1
- https://ubuntu.com/security/notices/USN-6898-2
- https://ubuntu.com/security/notices/USN-6898-3
- https://ubuntu.com/security/notices/USN-6898-4
- https://ubuntu.com/security/notices/USN-6917-1
- https://ubuntu.com/security/notices/USN-6918-1
- https://ubuntu.com/security/notices/USN-6919-1
- https://ubuntu.com/security/notices/USN-6927-1
- https://ubuntu.com/security/notices/USN-7019-1
- https://ubuntu.com/security/notices/USN-7428-1
- https://ubuntu.com/security/notices/USN-7428-2
- https://www.cve.org/CVERecord?id=CVE-2024-35960