UBUNTU-CVE-2024-47720
In the Linux kernel, the following vulnerability has been resolved: drm/amd/display: Add null check for set_output_gamma in dcn30_set_output_transfer_func This commit adds a null check for the set_output_gamma function pointer in the dcn30_set_output_transfer_func function. Previously, set_output_gamma was being checked for nullity at line 386, but then it was being dereferenced without any nullity check at line 401. This could potentially lead to a null pointer dereference error if set_output_gamma is indeed null. To fix this, we now ensure that set_output_gamma is not null before dereferencing it. We do this by adding a nullity check for set_output_gamma before the call to set_output_gamma at line 401. If set_output_gamma is null, we log an error message and do not call the function. This fix prevents a potential null pointer dereference error. drivers/gpu/drm/amd/amdgpu/../display/dc/hwss/dcn30/dcn30_hwseq.c:401 dcn30_set_output_transfer_func() error: we previously assumed 'mpc->funcs->set_output_gamma' could be null (see line 386) drivers/gpu/drm/amd/amdgpu/../display/dc/hwss/dcn30/dcn30_hwseq.c 373 bool dcn30_set_output_transfer_func(struct dc *dc, 374 struct pipe_ctx *pipe_ctx, 375 const struct dc_stream_state *stream) 376 { 377 int mpcc_id = pipe_ctx->plane_res.hubp->inst; 378 struct mpc *mpc = pipe_ctx->stream_res.opp->ctx->dc->res_pool->mpc; 379 const struct pwl_params *params = NULL; 380 bool ret = false; 381 382 /* program OGAM or 3DLUT only for the top pipe*/ 383 if (pipe_ctx->top_pipe == NULL) { 384 /*program rmu shaper and 3dlut in MPC*/ 385 ret = dcn30_set_mpc_shaper_3dlut(pipe_ctx, stream); 386 if (ret == false && mpc->funcs->set_output_gamma) { ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ If this is NULL 387 if (stream->out_transfer_func.type == TF_TYPE_HWPWL) 388 params = &stream->out_transfer_func.pwl; 389 else if (pipe_ctx->stream->out_transfer_func.type == 390 TF_TYPE_DISTRIBUTED_POINTS && 391 cm3_helper_translate_curve_to_hw_format( 392 &stream->out_transfer_func, 393 &mpc->blender_params, false)) 394 params = &mpc->blender_params; 395 /* there are no ROM LUTs in OUTGAM */ 396 if (stream->out_transfer_func.type == TF_TYPE_PREDEFINED) 397 BREAK_TO_DEBUGGER(); 398 } 399 } 400 --> 401 mpc->funcs->set_output_gamma(mpc, mpcc_id, params); ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Then it will crash 402 return ret; 403 }
02 / AFFECTED SOFTWARE
Affected packages
6 explicit affected versions
17 explicit affected versions
4 explicit affected versions
7 explicit affected versions
12 explicit affected versions
33 explicit affected versions
7 explicit affected versions
1 explicit affected versions
1 explicit affected versions
11 explicit affected versions
39 explicit affected versions
53 explicit affected versions
26 explicit affected versions
50 explicit affected versions
12 explicit affected versions
19 explicit affected versions
6 explicit affected versions
63 explicit affected versions
48 explicit affected versions
58 explicit affected versions
49 explicit affected versions
10 explicit affected versions
11 explicit affected versions
17 explicit affected versions
55 explicit affected versions
7 explicit affected versions
54 explicit affected versions
12 explicit affected versions
13 explicit affected versions
14 explicit affected versions
35 explicit affected versions
15 explicit affected versions
18 explicit affected versions
18 explicit affected versions
16 explicit affected versions
64 explicit affected versions
17 explicit affected versions
13 explicit affected versions
23 explicit affected versions
22 explicit affected versions
21 explicit affected versions
16 explicit affected versions
10 explicit affected versions
18 explicit affected versions
10 explicit affected versions
10 explicit affected versions
1 explicit affected versions
46 explicit affected versions
12 explicit affected versions
14 explicit affected versions
7 explicit affected versions
12 explicit affected versions
12 explicit affected versions
12 explicit affected versions
14 explicit affected versions
11 explicit affected versions
4 explicit affected versions
37 explicit affected versions
1 explicit affected versions
13 explicit affected versions
26 explicit affected versions
13 explicit affected versions
10 explicit affected versions
29 explicit affected versions
13 explicit affected versions
60 explicit affected versions
11 explicit affected versions
12 explicit affected versions
57 explicit affected versions
19 explicit affected versions
33 explicit affected versions
23 explicit affected versions
10 explicit affected versions
1 explicit affected versions
3 explicit affected versions
11 explicit affected versions
12 explicit affected versions
7 explicit affected versions
12 explicit affected versions
1 explicit affected versions
46 explicit affected versions
40 explicit affected versions
56 explicit affected versions
10 explicit affected versions
26 explicit affected versions
13 explicit affected versions
18 explicit affected versions
1 explicit affected versions
10 explicit affected versions
20 explicit affected versions
13 explicit affected versions
19 explicit affected versions
16 explicit affected versions
59 explicit affected versions
20 explicit affected versions
47 explicit affected versions
2 explicit affected versions
51 explicit affected versions
7 explicit affected versions
17 explicit affected versions
8 explicit affected versions
12 explicit affected versions
45 explicit affected versions
27 explicit affected versions
31 explicit affected versions
13 explicit affected versions
20 explicit affected versions
5 explicit affected versions
8 explicit affected versions
10 explicit affected versions
16 explicit affected versions
13 explicit affected versions
7 explicit affected versions
2 explicit affected versions
50 explicit affected versions
10 explicit affected versions
14 explicit affected versions
12 explicit affected versions
44 explicit affected versions
16 explicit affected versions
3 explicit affected versions
13 explicit affected versions
45 explicit affected versions
37 explicit affected versions
21 explicit affected versions
14 explicit affected versions
11 explicit affected versions
38 explicit affected versions
49 explicit affected versions
9 explicit affected versions
48 explicit affected versions
11 explicit affected versions
56 explicit affected versions
7 explicit affected versions
29 explicit affected versions
4 explicit affected versions
1 explicit affected versions
54 explicit affected versions
13 explicit affected versions
43 explicit affected versions
10 explicit affected versions
8 explicit affected versions
15 explicit affected versions
14 explicit affected versions
4 explicit affected versions
11 explicit affected versions
1 explicit affected versions
12 explicit affected versions
03 / CONNECTIONS
Connected vulnerabilities
04 / EVIDENCE
Source records
In the Linux kernel, the following vulnerability has been resolved: drm/amd/display: Add null check for set_output_gamma in dcn30_set_output_transfer_func This commit adds a null check for the set_output_gamma function pointer in the dcn30_set_output_transfer_func function. Previously, set_output_gamma was being checked for nullity at line 386, but then it was being dereferenced without any nullity check at line 401. This could potentially lead to a null pointer dereference error if set_output_gamma is indeed null. To fix this, we now ensure that set_output_gamma is not null before dereferencing it. We do this by adding a nullity check for set_output_gamma before the call to set_output_gamma at line 401. If set_output_gamma is null, we log an error message and do not call the function. This fix prevents a potential null pointer dereference error. drivers/gpu/drm/amd/amdgpu/../display/dc/hwss/dcn30/dcn30_hwseq.c:401 dcn30_set_output_transfer_func() error: we previously assumed 'mpc->funcs->set_output_gamma' could be null (see line 386) drivers/gpu/drm/amd/amdgpu/../display/dc/hwss/dcn30/dcn30_hwseq.c 373 bool dcn30_set_output_transfer_func(struct dc *dc, 374 struct pipe_ctx *pipe_ctx, 375 const struct dc_stream_state *stream) 376 { 377 int mpcc_id = pipe_ctx->plane_res.hubp->inst; 378 struct mpc *mpc = pipe_ctx->stream_res.opp->ctx->dc->res_pool->mpc; 379 const struct pwl_params *params = NULL; 380 bool ret = false; 381 382 /* program OGAM or 3DLUT only for the top pipe*/ 383 if (pipe_ctx->top_pipe == NULL) { 384 /*program rmu shaper and 3dlut in MPC*/ 385 ret = dcn30_set_mpc_shaper_3dlut(pipe_ctx, stream); 386 if (ret == false && mpc->funcs->set_output_gamma) { ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ If this is NULL 387 if (stream->out_transfer_func.type == TF_TYPE_HWPWL) 388 params = &stream->out_transfer_func.pwl; 389 else if (pipe_ctx->stream->out_transfer_func.type == 390 TF_TYPE_DISTRIBUTED_POINTS && 391 cm3_helper_translate_curve_to_hw_format( 392 &stream->out_transfer_func, 393 &mpc->blender_params, false)) 394 params = &mpc->blender_params; 395 /* there are no ROM LUTs in OUTGAM */ 396 if (stream->out_transfer_func.type == TF_TYPE_PREDEFINED) 397 BREAK_TO_DEBUGGER(); 398 } 399 } 400 --> 401 mpc->funcs->set_output_gamma(mpc, mpcc_id, params); ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Then it will crash 402 return ret; 403 }
05 / REFERENCES
Further evidence
- https://git.kernel.org/linus/08ae395ea22fb3d9b318c8bde28c0dfd2f5fa4d2
- https://git.kernel.org/stable/c/08ae395ea22fb3d9b318c8bde28c0dfd2f5fa4d2
- https://git.kernel.org/stable/c/44948d3cb943602ba4a0b5ed3c91ae0525838fb1
- https://git.kernel.org/stable/c/64886a4e6f1dce843c0889505cf0673b5211e16a
- https://git.kernel.org/stable/c/72ee32d0907364104fbcf4f68dd5ae63cd8eae9e
- https://git.kernel.org/stable/c/84edd5a3f5fa6aafa4afcaf9f101f46426c620c9
- https://git.kernel.org/stable/c/ddf9ff244d704e1903533f7be377615ed34b83e7
- https://ubuntu.com/security/CVE-2024-47720
- https://ubuntu.com/security/notices/USN-7166-1
- https://ubuntu.com/security/notices/USN-7166-2
- https://ubuntu.com/security/notices/USN-7166-3
- https://ubuntu.com/security/notices/USN-7166-4
- https://ubuntu.com/security/notices/USN-7186-1
- https://ubuntu.com/security/notices/USN-7186-2
- https://ubuntu.com/security/notices/USN-7194-1
- https://ubuntu.com/security/notices/USN-7276-1
- https://ubuntu.com/security/notices/USN-7277-1
- https://ubuntu.com/security/notices/USN-7301-1
- https://ubuntu.com/security/notices/USN-7303-1
- https://ubuntu.com/security/notices/USN-7303-2
- https://ubuntu.com/security/notices/USN-7303-3
- https://ubuntu.com/security/notices/USN-7304-1
- https://ubuntu.com/security/notices/USN-7310-1
- https://ubuntu.com/security/notices/USN-7311-1
- https://ubuntu.com/security/notices/USN-7384-1
- https://ubuntu.com/security/notices/USN-7384-2
- https://ubuntu.com/security/notices/USN-7385-1
- https://ubuntu.com/security/notices/USN-7386-1
- https://ubuntu.com/security/notices/USN-7403-1
- https://ubuntu.com/security/notices/USN-7468-1
- https://www.cve.org/CVERecord?id=CVE-2024-47720