UBUNTU-CVE-2024-50265
In the Linux kernel, the following vulnerability has been resolved: ocfs2: remove entry once instead of null-ptr-dereference in ocfs2_xa_remove() Syzkaller is able to provoke null-ptr-dereference in ocfs2_xa_remove(): [ 57.319872] (a.out,1161,7):ocfs2_xa_remove:2028 ERROR: status = -12 [ 57.320420] (a.out,1161,7):ocfs2_xa_cleanup_value_truncate:1999 ERROR: Partial truncate while removing xattr overlay.upper. Leaking 1 clusters and removing the entry [ 57.321727] BUG: kernel NULL pointer dereference, address: 0000000000000004 [...] [ 57.325727] RIP: 0010:ocfs2_xa_block_wipe_namevalue+0x2a/0xc0 [...] [ 57.331328] Call Trace: [ 57.331477] <TASK> [...] [ 57.333511] ? do_user_addr_fault+0x3e5/0x740 [ 57.333778] ? exc_page_fault+0x70/0x170 [ 57.334016] ? asm_exc_page_fault+0x2b/0x30 [ 57.334263] ? __pfx_ocfs2_xa_block_wipe_namevalue+0x10/0x10 [ 57.334596] ? ocfs2_xa_block_wipe_namevalue+0x2a/0xc0 [ 57.334913] ocfs2_xa_remove_entry+0x23/0xc0 [ 57.335164] ocfs2_xa_set+0x704/0xcf0 [ 57.335381] ? _raw_spin_unlock+0x1a/0x40 [ 57.335620] ? ocfs2_inode_cache_unlock+0x16/0x20 [ 57.335915] ? trace_preempt_on+0x1e/0x70 [ 57.336153] ? start_this_handle+0x16c/0x500 [ 57.336410] ? preempt_count_sub+0x50/0x80 [ 57.336656] ? _raw_read_unlock+0x20/0x40 [ 57.336906] ? start_this_handle+0x16c/0x500 [ 57.337162] ocfs2_xattr_block_set+0xa6/0x1e0 [ 57.337424] __ocfs2_xattr_set_handle+0x1fd/0x5d0 [ 57.337706] ? ocfs2_start_trans+0x13d/0x290 [ 57.337971] ocfs2_xattr_set+0xb13/0xfb0 [ 57.338207] ? dput+0x46/0x1c0 [ 57.338393] ocfs2_xattr_trusted_set+0x28/0x30 [ 57.338665] ? ocfs2_xattr_trusted_set+0x28/0x30 [ 57.338948] __vfs_removexattr+0x92/0xc0 [ 57.339182] __vfs_removexattr_locked+0xd5/0x190 [ 57.339456] ? preempt_count_sub+0x50/0x80 [ 57.339705] vfs_removexattr+0x5f/0x100 [...] Reproducer uses faultinject facility to fail ocfs2_xa_remove() -> ocfs2_xa_value_truncate() with -ENOMEM. In this case the comment mentions that we can return 0 if ocfs2_xa_cleanup_value_truncate() is going to wipe the entry anyway. But the following 'rc' check is wrong and execution flow do 'ocfs2_xa_remove_entry(loc);' twice: * 1st: in ocfs2_xa_cleanup_value_truncate(); * 2nd: returning back to ocfs2_xa_remove() instead of going to 'out'. Fix this by skipping the 2nd removal of the same entry and making syzkaller repro happy.
02 / AFFECTED SOFTWARE
Affected packages
6 explicit affected versions
10 explicit affected versions
41 explicit affected versions
21 explicit affected versions
101 explicit affected versions
1 explicit affected versions
1 explicit affected versions
21 explicit affected versions
16 explicit affected versions
10 explicit affected versions
34 explicit affected versions
1 explicit affected versions
8 explicit affected versions
24 explicit affected versions
5 explicit affected versions
8 explicit affected versions
1 explicit affected versions
10 explicit affected versions
1 explicit affected versions
1 explicit affected versions
1 explicit affected versions
2 explicit affected versions
26 explicit affected versions
16 explicit affected versions
4 explicit affected versions
11 explicit affected versions
41 explicit affected versions
57 explicit affected versions
50 explicit affected versions
12 explicit affected versions
19 explicit affected versions
6 explicit affected versions
67 explicit affected versions
21 explicit affected versions
52 explicit affected versions
72 explicit affected versions
60 explicit affected versions
53 explicit affected versions
58 explicit affected versions
12 explicit affected versions
19 explicit affected versions
59 explicit affected versions
191 explicit affected versions
7 explicit affected versions
99 explicit affected versions
13 explicit affected versions
70 explicit affected versions
18 explicit affected versions
35 explicit affected versions
19 explicit affected versions
19 explicit affected versions
18 explicit affected versions
18 explicit affected versions
101 explicit affected versions
13 explicit affected versions
4 explicit affected versions
23 explicit affected versions
106 explicit affected versions
26 explicit affected versions
56 explicit affected versions
22 explicit affected versions
7 explicit affected versions
12 explicit affected versions
1 explicit affected versions
50 explicit affected versions
12 explicit affected versions
14 explicit affected versions
7 explicit affected versions
2 explicit affected versions
88 explicit affected versions
12 explicit affected versions
104 explicit affected versions
112 explicit affected versions
12 explicit affected versions
16 explicit affected versions
99 explicit affected versions
105 explicit affected versions
15 explicit affected versions
13 explicit affected versions
13 explicit affected versions
14 explicit affected versions
10 explicit affected versions
8 explicit affected versions
10 explicit affected versions
173 explicit affected versions
37 explicit affected versions
1 explicit affected versions
37 explicit affected versions
26 explicit affected versions
13 explicit affected versions
12 explicit affected versions
17 explicit affected versions
1 explicit affected versions
29 explicit affected versions
92 explicit affected versions
13 explicit affected versions
64 explicit affected versions
15 explicit affected versions
16 explicit affected versions
1 explicit affected versions
87 explicit affected versions
59 explicit affected versions
104 explicit affected versions
22 explicit affected versions
33 explicit affected versions
23 explicit affected versions
10 explicit affected versions
1 explicit affected versions
99 explicit affected versions
11 explicit affected versions
12 explicit affected versions
122 explicit affected versions
7 explicit affected versions
12 explicit affected versions
102 explicit affected versions
2 explicit affected versions
50 explicit affected versions
44 explicit affected versions
11 explicit affected versions
115 explicit affected versions
60 explicit affected versions
150 explicit affected versions
136 explicit affected versions
10 explicit affected versions
26 explicit affected versions
20 explicit affected versions
37 explicit affected versions
1 explicit affected versions
23 explicit affected versions
13 explicit affected versions
21 explicit affected versions
122 explicit affected versions
62 explicit affected versions
16 explicit affected versions
63 explicit affected versions
24 explicit affected versions
51 explicit affected versions
3 explicit affected versions
80 explicit affected versions
76 explicit affected versions
1 explicit affected versions
1 explicit affected versions
2 explicit affected versions
69 explicit affected versions
51 explicit affected versions
75 explicit affected versions
7 explicit affected versions
20 explicit affected versions
12 explicit affected versions
47 explicit affected versions
27 explicit affected versions
34 explicit affected versions
1 explicit affected versions
1 explicit affected versions
7 explicit affected versions
20 explicit affected versions
13 explicit affected versions
91 explicit affected versions
13 explicit affected versions
55 explicit affected versions
77 explicit affected versions
52 explicit affected versions
10 explicit affected versions
12 explicit affected versions
15 explicit affected versions
91 explicit affected versions
44 explicit affected versions
16 explicit affected versions
3 explicit affected versions
13 explicit affected versions
45 explicit affected versions
37 explicit affected versions
25 explicit affected versions
14 explicit affected versions
38 explicit affected versions
52 explicit affected versions
9 explicit affected versions
51 explicit affected versions
11 explicit affected versions
15 explicit affected versions
7 explicit affected versions
60 explicit affected versions
7 explicit affected versions
33 explicit affected versions
83 explicit affected versions
63 explicit affected versions
126 explicit affected versions
105 explicit affected versions
58 explicit affected versions
98 explicit affected versions
13 explicit affected versions
43 explicit affected versions
8 explicit affected versions
57 explicit affected versions
129 explicit affected versions
150 explicit affected versions
10 explicit affected versions
19 explicit affected versions
14 explicit affected versions
92 explicit affected versions
4 explicit affected versions
78 explicit affected versions
11 explicit affected versions
1 explicit affected versions
52 explicit affected versions
14 explicit affected versions
03 / CONNECTIONS
Connected vulnerabilities
04 / EVIDENCE
Source records
In the Linux kernel, the following vulnerability has been resolved: ocfs2: remove entry once instead of null-ptr-dereference in ocfs2_xa_remove() Syzkaller is able to provoke null-ptr-dereference in ocfs2_xa_remove(): [ 57.319872] (a.out,1161,7):ocfs2_xa_remove:2028 ERROR: status = -12 [ 57.320420] (a.out,1161,7):ocfs2_xa_cleanup_value_truncate:1999 ERROR: Partial truncate while removing xattr overlay.upper. Leaking 1 clusters and removing the entry [ 57.321727] BUG: kernel NULL pointer dereference, address: 0000000000000004 [...] [ 57.325727] RIP: 0010:ocfs2_xa_block_wipe_namevalue+0x2a/0xc0 [...] [ 57.331328] Call Trace: [ 57.331477] <TASK> [...] [ 57.333511] ? do_user_addr_fault+0x3e5/0x740 [ 57.333778] ? exc_page_fault+0x70/0x170 [ 57.334016] ? asm_exc_page_fault+0x2b/0x30 [ 57.334263] ? __pfx_ocfs2_xa_block_wipe_namevalue+0x10/0x10 [ 57.334596] ? ocfs2_xa_block_wipe_namevalue+0x2a/0xc0 [ 57.334913] ocfs2_xa_remove_entry+0x23/0xc0 [ 57.335164] ocfs2_xa_set+0x704/0xcf0 [ 57.335381] ? _raw_spin_unlock+0x1a/0x40 [ 57.335620] ? ocfs2_inode_cache_unlock+0x16/0x20 [ 57.335915] ? trace_preempt_on+0x1e/0x70 [ 57.336153] ? start_this_handle+0x16c/0x500 [ 57.336410] ? preempt_count_sub+0x50/0x80 [ 57.336656] ? _raw_read_unlock+0x20/0x40 [ 57.336906] ? start_this_handle+0x16c/0x500 [ 57.337162] ocfs2_xattr_block_set+0xa6/0x1e0 [ 57.337424] __ocfs2_xattr_set_handle+0x1fd/0x5d0 [ 57.337706] ? ocfs2_start_trans+0x13d/0x290 [ 57.337971] ocfs2_xattr_set+0xb13/0xfb0 [ 57.338207] ? dput+0x46/0x1c0 [ 57.338393] ocfs2_xattr_trusted_set+0x28/0x30 [ 57.338665] ? ocfs2_xattr_trusted_set+0x28/0x30 [ 57.338948] __vfs_removexattr+0x92/0xc0 [ 57.339182] __vfs_removexattr_locked+0xd5/0x190 [ 57.339456] ? preempt_count_sub+0x50/0x80 [ 57.339705] vfs_removexattr+0x5f/0x100 [...] Reproducer uses faultinject facility to fail ocfs2_xa_remove() -> ocfs2_xa_value_truncate() with -ENOMEM. In this case the comment mentions that we can return 0 if ocfs2_xa_cleanup_value_truncate() is going to wipe the entry anyway. But the following 'rc' check is wrong and execution flow do 'ocfs2_xa_remove_entry(loc);' twice: * 1st: in ocfs2_xa_cleanup_value_truncate(); * 2nd: returning back to ocfs2_xa_remove() instead of going to 'out'. Fix this by skipping the 2nd removal of the same entry and making syzkaller repro happy.
05 / REFERENCES
Further evidence
- https://git.kernel.org/linus/0b63c0e01fba40e3992bc627272ec7b618ccaef7
- https://git.kernel.org/stable/c/0b63c0e01fba40e3992bc627272ec7b618ccaef7
- https://git.kernel.org/stable/c/168a9b8303fcb0317db4c06b23ce1c0ce2af4e10
- https://git.kernel.org/stable/c/2b5369528ee63c88371816178a05b5e664c87386
- https://git.kernel.org/stable/c/38cbf13b2e7a31362babe411f7c2c3c52cd2734b
- https://git.kernel.org/stable/c/6a7e6dcf90fe7721d0863067b6ca9a9442134692
- https://git.kernel.org/stable/c/86dd0e8d42828923c68ad506933336bcd6f2317d
- https://git.kernel.org/stable/c/dcc8fe8c83145041cb6c80cac21f6173a3ff0204
- https://git.kernel.org/stable/c/dd73c942eed76a014c7a5597e6926435274d2c4c
- https://ubuntu.com/security/CVE-2024-50265
- https://ubuntu.com/security/notices/USN-7276-1
- https://ubuntu.com/security/notices/USN-7277-1
- https://ubuntu.com/security/notices/USN-7288-1
- https://ubuntu.com/security/notices/USN-7288-2
- https://ubuntu.com/security/notices/USN-7289-1
- https://ubuntu.com/security/notices/USN-7289-2
- https://ubuntu.com/security/notices/USN-7289-3
- https://ubuntu.com/security/notices/USN-7289-4
- https://ubuntu.com/security/notices/USN-7291-1
- https://ubuntu.com/security/notices/USN-7293-1
- https://ubuntu.com/security/notices/USN-7294-1
- https://ubuntu.com/security/notices/USN-7294-2
- https://ubuntu.com/security/notices/USN-7294-3
- https://ubuntu.com/security/notices/USN-7294-4
- https://ubuntu.com/security/notices/USN-7295-1
- https://ubuntu.com/security/notices/USN-7305-1
- https://ubuntu.com/security/notices/USN-7308-1
- https://ubuntu.com/security/notices/USN-7310-1
- https://ubuntu.com/security/notices/USN-7331-1
- https://ubuntu.com/security/notices/USN-7388-1
- https://ubuntu.com/security/notices/USN-7389-1
- https://ubuntu.com/security/notices/USN-7390-1
- https://ubuntu.com/security/notices/USN-7393-1
- https://ubuntu.com/security/notices/USN-7401-1
- https://ubuntu.com/security/notices/USN-7413-1
- https://ubuntu.com/security/notices/USN-7428-1
- https://ubuntu.com/security/notices/USN-7428-2
- https://ubuntu.com/security/notices/USN-7429-1
- https://ubuntu.com/security/notices/USN-7429-2
- https://ubuntu.com/security/notices/USN-7449-1
- https://ubuntu.com/security/notices/USN-7449-2
- https://ubuntu.com/security/notices/USN-7450-1
- https://ubuntu.com/security/notices/USN-7451-1
- https://ubuntu.com/security/notices/USN-7452-1
- https://ubuntu.com/security/notices/USN-7453-1
- https://ubuntu.com/security/notices/USN-7458-1
- https://ubuntu.com/security/notices/USN-7468-1
- https://ubuntu.com/security/notices/USN-7523-1
- https://ubuntu.com/security/notices/USN-7524-1
- https://ubuntu.com/security/notices/USN-7539-1
- https://ubuntu.com/security/notices/USN-7540-1
- https://www.cve.org/CVERecord?id=CVE-2024-50265