UBUNTU-CVE-2024-57979
In the Linux kernel, the following vulnerability has been resolved: pps: Fix a use-after-free On a board running ntpd and gpsd, I'm seeing a consistent use-after-free in sys_exit() from gpsd when rebooting: pps pps1: removed ------------[ cut here ]------------ kobject: '(null)' (00000000db4bec24): is not initialized, yet kobject_put() is being called. WARNING: CPU: 2 PID: 440 at lib/kobject.c:734 kobject_put+0x120/0x150 CPU: 2 UID: 299 PID: 440 Comm: gpsd Not tainted 6.11.0-rc6-00308-gb31c44928842 #1 Hardware name: Raspberry Pi 4 Model B Rev 1.1 (DT) pstate: 60000005 (nZCv daif -PAN -UAO -TCO -DIT -SSBS BTYPE=--) pc : kobject_put+0x120/0x150 lr : kobject_put+0x120/0x150 sp : ffffffc0803d3ae0 x29: ffffffc0803d3ae0 x28: ffffff8042dc9738 x27: 0000000000000001 x26: 0000000000000000 x25: ffffff8042dc9040 x24: ffffff8042dc9440 x23: ffffff80402a4620 x22: ffffff8042ef4bd0 x21: ffffff80405cb600 x20: 000000000008001b x19: ffffff8040b3b6e0 x18: 0000000000000000 x17: 0000000000000000 x16: 0000000000000000 x15: 696e6920746f6e20 x14: 7369203a29343263 x13: 205d303434542020 x12: 0000000000000000 x11: 0000000000000000 x10: 0000000000000000 x9 : 0000000000000000 x8 : 0000000000000000 x7 : 0000000000000000 x6 : 0000000000000000 x5 : 0000000000000000 x4 : 0000000000000000 x3 : 0000000000000000 x2 : 0000000000000000 x1 : 0000000000000000 x0 : 0000000000000000 Call trace: kobject_put+0x120/0x150 cdev_put+0x20/0x3c __fput+0x2c4/0x2d8 ____fput+0x1c/0x38 task_work_run+0x70/0xfc do_exit+0x2a0/0x924 do_group_exit+0x34/0x90 get_signal+0x7fc/0x8c0 do_signal+0x128/0x13b4 do_notify_resume+0xdc/0x160 el0_svc+0xd4/0xf8 el0t_64_sync_handler+0x140/0x14c el0t_64_sync+0x190/0x194 ---[ end trace 0000000000000000 ]--- ...followed by more symptoms of corruption, with similar stacks: refcount_t: underflow; use-after-free. kernel BUG at lib/list_debug.c:62! Kernel panic - not syncing: Oops - BUG: Fatal exception This happens because pps_device_destruct() frees the pps_device with the embedded cdev immediately after calling cdev_del(), but, as the comment above cdev_del() notes, fops for previously opened cdevs are still callable even after cdev_del() returns. I think this bug has always been there: I can't explain why it suddenly started happening every time I reboot this particular board. In commit d953e0e837e6 ("pps: Fix a use-after free bug when unregistering a source."), George Spelvin suggested removing the embedded cdev. That seems like the simplest way to fix this, so I've implemented his suggestion, using __register_chrdev() with pps_idr becoming the source of truth for which minor corresponds to which device. But now that pps_idr defines userspace visibility instead of cdev_add(), we need to be sure the pps->dev refcount can't reach zero while userspace can still find it again. So, the idr_remove() call moves to pps_unregister_cdev(), and pps_idr now holds a reference to pps->dev. pps_core: source serial1 got cdev (251:1) <...> pps pps1: removed pps_core: unregistering pps1 pps_core: deallocating pps1
02 / AFFECTED SOFTWARE
Affected packages
12 explicit affected versions
11 explicit affected versions
53 explicit affected versions
27 explicit affected versions
39 explicit affected versions
45 explicit affected versions
63 explicit affected versions
50 explicit affected versions
6 explicit affected versions
12 explicit affected versions
19 explicit affected versions
6 explicit affected versions
73 explicit affected versions
24 explicit affected versions
58 explicit affected versions
76 explicit affected versions
66 explicit affected versions
59 explicit affected versions
10 explicit affected versions
17 explicit affected versions
24 explicit affected versions
65 explicit affected versions
191 explicit affected versions
7 explicit affected versions
64 explicit affected versions
21 explicit affected versions
104 explicit affected versions
13 explicit affected versions
85 explicit affected versions
23 explicit affected versions
35 explicit affected versions
25 explicit affected versions
23 explicit affected versions
18 explicit affected versions
24 explicit affected versions
118 explicit affected versions
64 explicit affected versions
26 explicit affected versions
106 explicit affected versions
13 explicit affected versions
4 explicit affected versions
121 explicit affected versions
23 explicit affected versions
31 explicit affected versions
1 explicit affected versions
1 explicit affected versions
21 explicit affected versions
16 explicit affected versions
10 explicit affected versions
60 explicit affected versions
27 explicit affected versions
5 explicit affected versions
7 explicit affected versions
12 explicit affected versions
111 explicit affected versions
4 explicit affected versions
56 explicit affected versions
12 explicit affected versions
14 explicit affected versions
1 explicit affected versions
7 explicit affected versions
2 explicit affected versions
93 explicit affected versions
12 explicit affected versions
109 explicit affected versions
117 explicit affected versions
12 explicit affected versions
21 explicit affected versions
104 explicit affected versions
120 explicit affected versions
19 explicit affected versions
18 explicit affected versions
13 explicit affected versions
10 explicit affected versions
37 explicit affected versions
5 explicit affected versions
13 explicit affected versions
19 explicit affected versions
10 explicit affected versions
40 explicit affected versions
1 explicit affected versions
26 explicit affected versions
40 explicit affected versions
13 explicit affected versions
144 explicit affected versions
14 explicit affected versions
1 explicit affected versions
29 explicit affected versions
96 explicit affected versions
13 explicit affected versions
70 explicit affected versions
20 explicit affected versions
21 explicit affected versions
1 explicit affected versions
87 explicit affected versions
65 explicit affected versions
108 explicit affected versions
28 explicit affected versions
33 explicit affected versions
23 explicit affected versions
10 explicit affected versions
1 explicit affected versions
188 explicit affected versions
11 explicit affected versions
12 explicit affected versions
7 explicit affected versions
12 explicit affected versions
107 explicit affected versions
138 explicit affected versions
2 explicit affected versions
56 explicit affected versions
50 explicit affected versions
132 explicit affected versions
66 explicit affected versions
165 explicit affected versions
154 explicit affected versions
10 explicit affected versions
26 explicit affected versions
25 explicit affected versions
41 explicit affected versions
1 explicit affected versions
14 explicit affected versions
26 explicit affected versions
13 explicit affected versions
26 explicit affected versions
139 explicit affected versions
64 explicit affected versions
16 explicit affected versions
67 explicit affected versions
29 explicit affected versions
54 explicit affected versions
116 explicit affected versions
3 explicit affected versions
93 explicit affected versions
1 explicit affected versions
4 explicit affected versions
1 explicit affected versions
1 explicit affected versions
98 explicit affected versions
2 explicit affected versions
22 explicit affected versions
8 explicit affected versions
74 explicit affected versions
51 explicit affected versions
92 explicit affected versions
30 explicit affected versions
5 explicit affected versions
8 explicit affected versions
1 explicit affected versions
10 explicit affected versions
4 explicit affected versions
25 explicit affected versions
13 explicit affected versions
96 explicit affected versions
13 explicit affected versions
23 explicit affected versions
13 explicit affected versions
59 explicit affected versions
7 explicit affected versions
140 explicit affected versions
3 explicit affected versions
94 explicit affected versions
57 explicit affected versions
10 explicit affected versions
12 explicit affected versions
15 explicit affected versions
94 explicit affected versions
44 explicit affected versions
16 explicit affected versions
3 explicit affected versions
13 explicit affected versions
26 explicit affected versions
45 explicit affected versions
37 explicit affected versions
30 explicit affected versions
14 explicit affected versions
38 explicit affected versions
167 explicit affected versions
9 explicit affected versions
55 explicit affected versions
11 explicit affected versions
19 explicit affected versions
7 explicit affected versions
66 explicit affected versions
7 explicit affected versions
35 explicit affected versions
97 explicit affected versions
67 explicit affected versions
121 explicit affected versions
4 explicit affected versions
1 explicit affected versions
1 explicit affected versions
1 explicit affected versions
64 explicit affected versions
56 explicit affected versions
13 explicit affected versions
43 explicit affected versions
62 explicit affected versions
10 explicit affected versions
8 explicit affected versions
24 explicit affected versions
14 explicit affected versions
92 explicit affected versions
4 explicit affected versions
78 explicit affected versions
11 explicit affected versions
1 explicit affected versions
69 explicit affected versions
19 explicit affected versions
03 / CONNECTIONS
Connected vulnerabilities
04 / EVIDENCE
Source records
In the Linux kernel, the following vulnerability has been resolved: pps: Fix a use-after-free On a board running ntpd and gpsd, I'm seeing a consistent use-after-free in sys_exit() from gpsd when rebooting: pps pps1: removed ------------[ cut here ]------------ kobject: '(null)' (00000000db4bec24): is not initialized, yet kobject_put() is being called. WARNING: CPU: 2 PID: 440 at lib/kobject.c:734 kobject_put+0x120/0x150 CPU: 2 UID: 299 PID: 440 Comm: gpsd Not tainted 6.11.0-rc6-00308-gb31c44928842 #1 Hardware name: Raspberry Pi 4 Model B Rev 1.1 (DT) pstate: 60000005 (nZCv daif -PAN -UAO -TCO -DIT -SSBS BTYPE=--) pc : kobject_put+0x120/0x150 lr : kobject_put+0x120/0x150 sp : ffffffc0803d3ae0 x29: ffffffc0803d3ae0 x28: ffffff8042dc9738 x27: 0000000000000001 x26: 0000000000000000 x25: ffffff8042dc9040 x24: ffffff8042dc9440 x23: ffffff80402a4620 x22: ffffff8042ef4bd0 x21: ffffff80405cb600 x20: 000000000008001b x19: ffffff8040b3b6e0 x18: 0000000000000000 x17: 0000000000000000 x16: 0000000000000000 x15: 696e6920746f6e20 x14: 7369203a29343263 x13: 205d303434542020 x12: 0000000000000000 x11: 0000000000000000 x10: 0000000000000000 x9 : 0000000000000000 x8 : 0000000000000000 x7 : 0000000000000000 x6 : 0000000000000000 x5 : 0000000000000000 x4 : 0000000000000000 x3 : 0000000000000000 x2 : 0000000000000000 x1 : 0000000000000000 x0 : 0000000000000000 Call trace: kobject_put+0x120/0x150 cdev_put+0x20/0x3c __fput+0x2c4/0x2d8 ____fput+0x1c/0x38 task_work_run+0x70/0xfc do_exit+0x2a0/0x924 do_group_exit+0x34/0x90 get_signal+0x7fc/0x8c0 do_signal+0x128/0x13b4 do_notify_resume+0xdc/0x160 el0_svc+0xd4/0xf8 el0t_64_sync_handler+0x140/0x14c el0t_64_sync+0x190/0x194 ---[ end trace 0000000000000000 ]--- ...followed by more symptoms of corruption, with similar stacks: refcount_t: underflow; use-after-free. kernel BUG at lib/list_debug.c:62! Kernel panic - not syncing: Oops - BUG: Fatal exception This happens because pps_device_destruct() frees the pps_device with the embedded cdev immediately after calling cdev_del(), but, as the comment above cdev_del() notes, fops for previously opened cdevs are still callable even after cdev_del() returns. I think this bug has always been there: I can't explain why it suddenly started happening every time I reboot this particular board. In commit d953e0e837e6 ("pps: Fix a use-after free bug when unregistering a source."), George Spelvin suggested removing the embedded cdev. That seems like the simplest way to fix this, so I've implemented his suggestion, using __register_chrdev() with pps_idr becoming the source of truth for which minor corresponds to which device. But now that pps_idr defines userspace visibility instead of cdev_add(), we need to be sure the pps->dev refcount can't reach zero while userspace can still find it again. So, the idr_remove() call moves to pps_unregister_cdev(), and pps_idr now holds a reference to pps->dev. pps_core: source serial1 got cdev (251:1) <...> pps pps1: removed pps_core: unregistering pps1 pps_core: deallocating pps1
05 / REFERENCES
Further evidence
- https://git.kernel.org/linus/c79a39dc8d060b9e64e8b0fa9d245d44befeefbe
- https://git.kernel.org/stable/c/7e5ee3281dc09014367f5112b6d566ba36ea2d49
- https://git.kernel.org/stable/c/85241f7de216f8298f6e48540ea13d7dcd100870
- https://git.kernel.org/stable/c/91932db1d96b2952299ce30c1c693d834d10ace6
- https://git.kernel.org/stable/c/c79a39dc8d060b9e64e8b0fa9d245d44befeefbe
- https://git.kernel.org/stable/c/cd3bbcb6b3a7caa5ce67de76723b6d8531fb7f64
- https://ubuntu.com/security/CVE-2024-57979
- https://ubuntu.com/security/notices/USN-7510-1
- https://ubuntu.com/security/notices/USN-7510-2
- https://ubuntu.com/security/notices/USN-7510-3
- https://ubuntu.com/security/notices/USN-7510-4
- https://ubuntu.com/security/notices/USN-7510-5
- https://ubuntu.com/security/notices/USN-7510-6
- https://ubuntu.com/security/notices/USN-7510-7
- https://ubuntu.com/security/notices/USN-7510-8
- https://ubuntu.com/security/notices/USN-7511-1
- https://ubuntu.com/security/notices/USN-7511-2
- https://ubuntu.com/security/notices/USN-7511-3
- https://ubuntu.com/security/notices/USN-7512-1
- https://ubuntu.com/security/notices/USN-7516-1
- https://ubuntu.com/security/notices/USN-7516-2
- https://ubuntu.com/security/notices/USN-7516-3
- https://ubuntu.com/security/notices/USN-7516-4
- https://ubuntu.com/security/notices/USN-7516-5
- https://ubuntu.com/security/notices/USN-7516-6
- https://ubuntu.com/security/notices/USN-7516-7
- https://ubuntu.com/security/notices/USN-7516-8
- https://ubuntu.com/security/notices/USN-7516-9
- https://ubuntu.com/security/notices/USN-7517-1
- https://ubuntu.com/security/notices/USN-7517-2
- https://ubuntu.com/security/notices/USN-7517-3
- https://ubuntu.com/security/notices/USN-7518-1
- https://ubuntu.com/security/notices/USN-7521-1
- https://ubuntu.com/security/notices/USN-7521-2
- https://ubuntu.com/security/notices/USN-7521-3
- https://ubuntu.com/security/notices/USN-7539-1
- https://ubuntu.com/security/notices/USN-7540-1
- https://ubuntu.com/security/notices/USN-7593-1
- https://ubuntu.com/security/notices/USN-7602-1
- https://ubuntu.com/security/notices/USN-7640-1
- https://ubuntu.com/security/notices/USN-7651-1
- https://ubuntu.com/security/notices/USN-7651-2
- https://ubuntu.com/security/notices/USN-7651-3
- https://ubuntu.com/security/notices/USN-7651-4
- https://ubuntu.com/security/notices/USN-7651-5
- https://ubuntu.com/security/notices/USN-7651-6
- https://ubuntu.com/security/notices/USN-7652-1
- https://ubuntu.com/security/notices/USN-7653-1
- https://ubuntu.com/security/notices/USN-7737-1
- https://www.cve.org/CVERecord?id=CVE-2024-57979