UBUNTU-CVE-2024-57996
In the Linux kernel, the following vulnerability has been resolved: net_sched: sch_sfq: don't allow 1 packet limit The current implementation does not work correctly with a limit of 1. iproute2 actually checks for this and this patch adds the check in kernel as well. This fixes the following syzkaller reported crash: UBSAN: array-index-out-of-bounds in net/sched/sch_sfq.c:210:6 index 65535 is out of range for type 'struct sfq_head[128]' CPU: 0 PID: 2569 Comm: syz-executor101 Not tainted 5.10.0-smp-DEV #1 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 09/13/2024 Call Trace: __dump_stack lib/dump_stack.c:79 [inline] dump_stack+0x125/0x19f lib/dump_stack.c:120 ubsan_epilogue lib/ubsan.c:148 [inline] __ubsan_handle_out_of_bounds+0xed/0x120 lib/ubsan.c:347 sfq_link net/sched/sch_sfq.c:210 [inline] sfq_dec+0x528/0x600 net/sched/sch_sfq.c:238 sfq_dequeue+0x39b/0x9d0 net/sched/sch_sfq.c:500 sfq_reset+0x13/0x50 net/sched/sch_sfq.c:525 qdisc_reset+0xfe/0x510 net/sched/sch_generic.c:1026 tbf_reset+0x3d/0x100 net/sched/sch_tbf.c:319 qdisc_reset+0xfe/0x510 net/sched/sch_generic.c:1026 dev_reset_queue+0x8c/0x140 net/sched/sch_generic.c:1296 netdev_for_each_tx_queue include/linux/netdevice.h:2350 [inline] dev_deactivate_many+0x6dc/0xc20 net/sched/sch_generic.c:1362 __dev_close_many+0x214/0x350 net/core/dev.c:1468 dev_close_many+0x207/0x510 net/core/dev.c:1506 unregister_netdevice_many+0x40f/0x16b0 net/core/dev.c:10738 unregister_netdevice_queue+0x2be/0x310 net/core/dev.c:10695 unregister_netdevice include/linux/netdevice.h:2893 [inline] __tun_detach+0x6b6/0x1600 drivers/net/tun.c:689 tun_detach drivers/net/tun.c:705 [inline] tun_chr_close+0x104/0x1b0 drivers/net/tun.c:3640 __fput+0x203/0x840 fs/file_table.c:280 task_work_run+0x129/0x1b0 kernel/task_work.c:185 exit_task_work include/linux/task_work.h:33 [inline] do_exit+0x5ce/0x2200 kernel/exit.c:931 do_group_exit+0x144/0x310 kernel/exit.c:1046 __do_sys_exit_group kernel/exit.c:1057 [inline] __se_sys_exit_group kernel/exit.c:1055 [inline] __x64_sys_exit_group+0x3b/0x40 kernel/exit.c:1055 do_syscall_64+0x6c/0xd0 entry_SYSCALL_64_after_hwframe+0x61/0xcb RIP: 0033:0x7fe5e7b52479 Code: Unable to access opcode bytes at RIP 0x7fe5e7b5244f. RSP: 002b:00007ffd3c800398 EFLAGS: 00000246 ORIG_RAX: 00000000000000e7 RAX: ffffffffffffffda RBX: 0000000000000000 RCX: 00007fe5e7b52479 RDX: 000000000000003c RSI: 00000000000000e7 RDI: 0000000000000000 RBP: 00007fe5e7bcd2d0 R08: ffffffffffffffb8 R09: 0000000000000014 R10: 0000000000000000 R11: 0000000000000246 R12: 00007fe5e7bcd2d0 R13: 0000000000000000 R14: 00007fe5e7bcdd20 R15: 00007fe5e7b24270 The crash can be also be reproduced with the following (with a tc recompiled to allow for sfq limits of 1): tc qdisc add dev dummy0 handle 1: root tbf rate 1Kbit burst 100b lat 1s ../iproute2-6.9.0/tc/tc qdisc add dev dummy0 handle 2: parent 1:10 sfq limit 1 ifconfig dummy0 up ping -I dummy0 -f -c2 -W0.1 8.8.8.8 sleep 1 Scenario that triggers the crash: * the first packet is sent and queued in TBF and SFQ; qdisc qlen is 1 * TBF dequeues: it peeks from SFQ which moves the packet to the gso_skb list and keeps qdisc qlen set to 1. TBF is out of tokens so it schedules itself for later. * the second packet is sent and TBF tries to queues it to SFQ. qdisc qlen is now 2 and because the SFQ limit is 1 the packet is dropped by SFQ. At this point qlen is 1, and all of the SFQ slots are empty, however q->tail is not NULL. At this point, assuming no more packets are queued, when sch_dequeue runs again it will decrement the qlen for the current empty slot causing an underflow and the subsequent out of bounds access.
02 / AFFECTED SOFTWARE
Affected packages
68 explicit affected versions
1 explicit affected versions
1 explicit affected versions
85 explicit affected versions
106 explicit affected versions
22 explicit affected versions
10 explicit affected versions
25 explicit affected versions
8 explicit affected versions
28 explicit affected versions
13 explicit affected versions
66 explicit affected versions
8 explicit affected versions
11 explicit affected versions
42 explicit affected versions
107 explicit affected versions
1 explicit affected versions
21 explicit affected versions
16 explicit affected versions
10 explicit affected versions
10 explicit affected versions
4 explicit affected versions
65 explicit affected versions
70 explicit affected versions
50 explicit affected versions
6 explicit affected versions
12 explicit affected versions
19 explicit affected versions
6 explicit affected versions
80 explicit affected versions
24 explicit affected versions
65 explicit affected versions
80 explicit affected versions
71 explicit affected versions
60 explicit affected versions
10 explicit affected versions
20 explicit affected versions
26 explicit affected versions
72 explicit affected versions
191 explicit affected versions
26 explicit affected versions
7 explicit affected versions
69 explicit affected versions
24 explicit affected versions
13 explicit affected versions
75 explicit affected versions
35 explicit affected versions
32 explicit affected versions
30 explicit affected versions
18 explicit affected versions
28 explicit affected versions
64 explicit affected versions
29 explicit affected versions
110 explicit affected versions
13 explicit affected versions
4 explicit affected versions
23 explicit affected versions
111 explicit affected versions
34 explicit affected versions
113 explicit affected versions
1 explicit affected versions
64 explicit affected versions
30 explicit affected versions
5 explicit affected versions
7 explicit affected versions
12 explicit affected versions
4 explicit affected versions
12 explicit affected versions
14 explicit affected versions
10 explicit affected versions
12 explicit affected versions
1 explicit affected versions
7 explicit affected versions
4 explicit affected versions
96 explicit affected versions
19 explicit affected versions
13 explicit affected versions
96 explicit affected versions
12 explicit affected versions
24 explicit affected versions
110 explicit affected versions
26 explicit affected versions
16 explicit affected versions
10 explicit affected versions
178 explicit affected versions
37 explicit affected versions
6 explicit affected versions
47 explicit affected versions
1 explicit affected versions
26 explicit affected versions
1 explicit affected versions
13 explicit affected versions
19 explicit affected versions
1 explicit affected versions
29 explicit affected versions
100 explicit affected versions
13 explicit affected versions
77 explicit affected versions
23 explicit affected versions
24 explicit affected versions
1 explicit affected versions
91 explicit affected versions
72 explicit affected versions
35 explicit affected versions
33 explicit affected versions
1 explicit affected versions
23 explicit affected versions
41 explicit affected versions
10 explicit affected versions
2 explicit affected versions
4 explicit affected versions
104 explicit affected versions
11 explicit affected versions
12 explicit affected versions
127 explicit affected versions
7 explicit affected versions
12 explicit affected versions
2 explicit affected versions
57 explicit affected versions
120 explicit affected versions
73 explicit affected versions
155 explicit affected versions
141 explicit affected versions
10 explicit affected versions
26 explicit affected versions
26 explicit affected versions
1 explicit affected versions
49 explicit affected versions
17 explicit affected versions
29 explicit affected versions
13 explicit affected versions
29 explicit affected versions
127 explicit affected versions
16 explicit affected versions
74 explicit affected versions
32 explicit affected versions
3 explicit affected versions
121 explicit affected versions
80 explicit affected versions
81 explicit affected versions
1 explicit affected versions
4 explicit affected versions
2 explicit affected versions
51 explicit affected versions
18 explicit affected versions
25 explicit affected versions
12 explicit affected versions
60 explicit affected versions
60 explicit affected versions
27 explicit affected versions
46 explicit affected versions
111 explicit affected versions
37 explicit affected versions
5 explicit affected versions
3 explicit affected versions
8 explicit affected versions
1 explicit affected versions
99 explicit affected versions
13 explicit affected versions
63 explicit affected versions
7 explicit affected versions
8 explicit affected versions
82 explicit affected versions
10 explicit affected versions
12 explicit affected versions
20 explicit affected versions
98 explicit affected versions
71 explicit affected versions
45 explicit affected versions
44 explicit affected versions
16 explicit affected versions
3 explicit affected versions
13 explicit affected versions
26 explicit affected versions
45 explicit affected versions
37 explicit affected versions
33 explicit affected versions
8 explicit affected versions
14 explicit affected versions
38 explicit affected versions
9 explicit affected versions
11 explicit affected versions
22 explicit affected versions
73 explicit affected versions
7 explicit affected versions
88 explicit affected versions
131 explicit affected versions
110 explicit affected versions
62 explicit affected versions
1 explicit affected versions
1 explicit affected versions
1 explicit affected versions
71 explicit affected versions
103 explicit affected versions
62 explicit affected versions
61 explicit affected versions
13 explicit affected versions
43 explicit affected versions
134 explicit affected versions
108 explicit affected versions
155 explicit affected versions
10 explicit affected versions
27 explicit affected versions
78 explicit affected versions
14 explicit affected versions
4 explicit affected versions
78 explicit affected versions
11 explicit affected versions
1 explicit affected versions
57 explicit affected versions
112 explicit affected versions
1 explicit affected versions
22 explicit affected versions
62 explicit affected versions
03 / CONNECTIONS
Connected vulnerabilities
04 / EVIDENCE
Source records
In the Linux kernel, the following vulnerability has been resolved: net_sched: sch_sfq: don't allow 1 packet limit The current implementation does not work correctly with a limit of 1. iproute2 actually checks for this and this patch adds the check in kernel as well. This fixes the following syzkaller reported crash: UBSAN: array-index-out-of-bounds in net/sched/sch_sfq.c:210:6 index 65535 is out of range for type 'struct sfq_head[128]' CPU: 0 PID: 2569 Comm: syz-executor101 Not tainted 5.10.0-smp-DEV #1 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 09/13/2024 Call Trace: __dump_stack lib/dump_stack.c:79 [inline] dump_stack+0x125/0x19f lib/dump_stack.c:120 ubsan_epilogue lib/ubsan.c:148 [inline] __ubsan_handle_out_of_bounds+0xed/0x120 lib/ubsan.c:347 sfq_link net/sched/sch_sfq.c:210 [inline] sfq_dec+0x528/0x600 net/sched/sch_sfq.c:238 sfq_dequeue+0x39b/0x9d0 net/sched/sch_sfq.c:500 sfq_reset+0x13/0x50 net/sched/sch_sfq.c:525 qdisc_reset+0xfe/0x510 net/sched/sch_generic.c:1026 tbf_reset+0x3d/0x100 net/sched/sch_tbf.c:319 qdisc_reset+0xfe/0x510 net/sched/sch_generic.c:1026 dev_reset_queue+0x8c/0x140 net/sched/sch_generic.c:1296 netdev_for_each_tx_queue include/linux/netdevice.h:2350 [inline] dev_deactivate_many+0x6dc/0xc20 net/sched/sch_generic.c:1362 __dev_close_many+0x214/0x350 net/core/dev.c:1468 dev_close_many+0x207/0x510 net/core/dev.c:1506 unregister_netdevice_many+0x40f/0x16b0 net/core/dev.c:10738 unregister_netdevice_queue+0x2be/0x310 net/core/dev.c:10695 unregister_netdevice include/linux/netdevice.h:2893 [inline] __tun_detach+0x6b6/0x1600 drivers/net/tun.c:689 tun_detach drivers/net/tun.c:705 [inline] tun_chr_close+0x104/0x1b0 drivers/net/tun.c:3640 __fput+0x203/0x840 fs/file_table.c:280 task_work_run+0x129/0x1b0 kernel/task_work.c:185 exit_task_work include/linux/task_work.h:33 [inline] do_exit+0x5ce/0x2200 kernel/exit.c:931 do_group_exit+0x144/0x310 kernel/exit.c:1046 __do_sys_exit_group kernel/exit.c:1057 [inline] __se_sys_exit_group kernel/exit.c:1055 [inline] __x64_sys_exit_group+0x3b/0x40 kernel/exit.c:1055 do_syscall_64+0x6c/0xd0 entry_SYSCALL_64_after_hwframe+0x61/0xcb RIP: 0033:0x7fe5e7b52479 Code: Unable to access opcode bytes at RIP 0x7fe5e7b5244f. RSP: 002b:00007ffd3c800398 EFLAGS: 00000246 ORIG_RAX: 00000000000000e7 RAX: ffffffffffffffda RBX: 0000000000000000 RCX: 00007fe5e7b52479 RDX: 000000000000003c RSI: 00000000000000e7 RDI: 0000000000000000 RBP: 00007fe5e7bcd2d0 R08: ffffffffffffffb8 R09: 0000000000000014 R10: 0000000000000000 R11: 0000000000000246 R12: 00007fe5e7bcd2d0 R13: 0000000000000000 R14: 00007fe5e7bcdd20 R15: 00007fe5e7b24270 The crash can be also be reproduced with the following (with a tc recompiled to allow for sfq limits of 1): tc qdisc add dev dummy0 handle 1: root tbf rate 1Kbit burst 100b lat 1s ../iproute2-6.9.0/tc/tc qdisc add dev dummy0 handle 2: parent 1:10 sfq limit 1 ifconfig dummy0 up ping -I dummy0 -f -c2 -W0.1 8.8.8.8 sleep 1 Scenario that triggers the crash: * the first packet is sent and queued in TBF and SFQ; qdisc qlen is 1 * TBF dequeues: it peeks from SFQ which moves the packet to the gso_skb list and keeps qdisc qlen set to 1. TBF is out of tokens so it schedules itself for later. * the second packet is sent and TBF tries to queues it to SFQ. qdisc qlen is now 2 and because the SFQ limit is 1 the packet is dropped by SFQ. At this point qlen is 1, and all of the SFQ slots are empty, however q->tail is not NULL. At this point, assuming no more packets are queued, when sch_dequeue runs again it will decrement the qlen for the current empty slot causing an underflow and the subsequent out of bounds access.
05 / REFERENCES
Further evidence
- https://git.kernel.org/linus/10685681bafce6febb39770f3387621bf5d67d0b
- https://git.kernel.org/stable/c/10685681bafce6febb39770f3387621bf5d67d0b
- https://git.kernel.org/stable/c/35d0137305ae2f97260a9047f445bd4434bd6cc7
- https://git.kernel.org/stable/c/7d8947f2153ee9c5ab4cb17861a11cc45f30e8c4
- https://git.kernel.org/stable/c/7fefc294204f10a3405f175f4ac2be16d63f135e
- https://git.kernel.org/stable/c/833e9a1c27b82024db7ff5038a51651f48f05e5e
- https://ubuntu.com/security/CVE-2024-57996
- https://ubuntu.com/security/notices/USN-7521-1
- https://ubuntu.com/security/notices/USN-7521-2
- https://ubuntu.com/security/notices/USN-7521-3
- https://ubuntu.com/security/notices/USN-7651-1
- https://ubuntu.com/security/notices/USN-7651-2
- https://ubuntu.com/security/notices/USN-7651-3
- https://ubuntu.com/security/notices/USN-7651-4
- https://ubuntu.com/security/notices/USN-7651-5
- https://ubuntu.com/security/notices/USN-7651-6
- https://ubuntu.com/security/notices/USN-7652-1
- https://ubuntu.com/security/notices/USN-7653-1
- https://ubuntu.com/security/notices/USN-7725-1
- https://ubuntu.com/security/notices/USN-7725-2
- https://ubuntu.com/security/notices/USN-7725-3
- https://ubuntu.com/security/notices/USN-7726-1
- https://ubuntu.com/security/notices/USN-7726-2
- https://ubuntu.com/security/notices/USN-7726-3
- https://ubuntu.com/security/notices/USN-7726-4
- https://ubuntu.com/security/notices/USN-7726-5
- https://ubuntu.com/security/notices/USN-7727-1
- https://ubuntu.com/security/notices/USN-7727-2
- https://ubuntu.com/security/notices/USN-7727-3
- https://ubuntu.com/security/notices/USN-7754-1
- https://ubuntu.com/security/notices/USN-7754-2
- https://ubuntu.com/security/notices/USN-7755-1
- https://ubuntu.com/security/notices/USN-7755-2
- https://ubuntu.com/security/notices/USN-7755-3
- https://ubuntu.com/security/notices/USN-7776-1
- https://ubuntu.com/security/notices/USN-7779-1
- https://ubuntu.com/security/notices/USN-7802-1
- https://ubuntu.com/security/notices/USN-7809-1
- https://ubuntu.com/security/notices/USN-7819-1
- https://ubuntu.com/security/notices/USN-7819-2
- https://ubuntu.com/security/notices/USN-7820-1
- https://ubuntu.com/security/notices/USN-7832-1
- https://www.cve.org/CVERecord?id=CVE-2024-57996