UBUNTU-CVE-2025-40254
In the Linux kernel, the following vulnerability has been resolved: net: openvswitch: remove never-working support for setting nsh fields The validation of the set(nsh(...)) action is completely wrong. It runs through the nsh_key_put_from_nlattr() function that is the same function that validates NSH keys for the flow match and the push_nsh() action. However, the set(nsh(...)) has a very different memory layout. Nested attributes in there are doubled in size in case of the masked set(). That makes proper validation impossible. There is also confusion in the code between the 'masked' flag, that says that the nested attributes are doubled in size containing both the value and the mask, and the 'is_mask' that says that the value we're parsing is the mask. This is causing kernel crash on trying to write into mask part of the match with SW_FLOW_KEY_PUT() during validation, while validate_nsh() doesn't allocate any memory for it: BUG: kernel NULL pointer dereference, address: 0000000000000018 #PF: supervisor read access in kernel mode #PF: error_code(0x0000) - not-present page PGD 1c2383067 P4D 1c2383067 PUD 20b703067 PMD 0 Oops: Oops: 0000 [#1] SMP NOPTI CPU: 8 UID: 0 Kdump: loaded Not tainted 6.17.0-rc4+ #107 PREEMPT(voluntary) RIP: 0010:nsh_key_put_from_nlattr+0x19d/0x610 [openvswitch] Call Trace: <TASK> validate_nsh+0x60/0x90 [openvswitch] validate_set.constprop.0+0x270/0x3c0 [openvswitch] __ovs_nla_copy_actions+0x477/0x860 [openvswitch] ovs_nla_copy_actions+0x8d/0x100 [openvswitch] ovs_packet_cmd_execute+0x1cc/0x310 [openvswitch] genl_family_rcv_msg_doit+0xdb/0x130 genl_family_rcv_msg+0x14b/0x220 genl_rcv_msg+0x47/0xa0 netlink_rcv_skb+0x53/0x100 genl_rcv+0x24/0x40 netlink_unicast+0x280/0x3b0 netlink_sendmsg+0x1f7/0x430 ____sys_sendmsg+0x36b/0x3a0 ___sys_sendmsg+0x87/0xd0 __sys_sendmsg+0x6d/0xd0 do_syscall_64+0x7b/0x2c0 entry_SYSCALL_64_after_hwframe+0x76/0x7e The third issue with this process is that while trying to convert the non-masked set into masked one, validate_set() copies and doubles the size of the OVS_KEY_ATTR_NSH as if it didn't have any nested attributes. It should be copying each nested attribute and doubling them in size independently. And the process must be properly reversed during the conversion back from masked to a non-masked variant during the flow dump. In the end, the only two outcomes of trying to use this action are either validation failure or a kernel crash. And if somehow someone manages to install a flow with such an action, it will most definitely not do what it is supposed to, since all the keys and the masks are mixed up. Fixing all the issues is a complex task as it requires re-writing most of the validation code. Given that and the fact that this functionality never worked since introduction, let's just remove it altogether. It's better to re-introduce it later with a proper implementation instead of trying to fix it in stable releases.
02 / AFFECTED SOFTWARE
Affected packages
10 explicit affected versions
7 explicit affected versions
39 explicit affected versions
13 explicit affected versions
110 explicit affected versions
13 explicit affected versions
72 explicit affected versions
7 explicit affected versions
140 explicit affected versions
8 explicit affected versions
94 explicit affected versions
10 explicit affected versions
12 explicit affected versions
9 explicit affected versions
30 explicit affected versions
108 explicit affected versions
80 explicit affected versions
56 explicit affected versions
44 explicit affected versions
16 explicit affected versions
3 explicit affected versions
13 explicit affected versions
26 explicit affected versions
45 explicit affected versions
37 explicit affected versions
44 explicit affected versions
14 explicit affected versions
38 explicit affected versions
167 explicit affected versions
9 explicit affected versions
10 explicit affected versions
11 explicit affected versions
32 explicit affected versions
15 explicit affected versions
7 explicit affected versions
83 explicit affected versions
8 explicit affected versions
7 explicit affected versions
121 explicit affected versions
4 explicit affected versions
72 explicit affected versions
1 explicit affected versions
1 explicit affected versions
1 explicit affected versions
1 explicit affected versions
81 explicit affected versions
72 explicit affected versions
71 explicit affected versions
13 explicit affected versions
43 explicit affected versions
77 explicit affected versions
8 explicit affected versions
119 explicit affected versions
10 explicit affected versions
8 explicit affected versions
38 explicit affected versions
88 explicit affected versions
14 explicit affected versions
4 explicit affected versions
78 explicit affected versions
7 explicit affected versions
11 explicit affected versions
1 explicit affected versions
69 explicit affected versions
123 explicit affected versions
12 explicit affected versions
32 explicit affected versions
71 explicit affected versions
11 explicit affected versions
53 explicit affected versions
116 explicit affected versions
80 explicit affected versions
50 explicit affected versions
6 explicit affected versions
12 explicit affected versions
19 explicit affected versions
10 explicit affected versions
6 explicit affected versions
90 explicit affected versions
24 explicit affected versions
75 explicit affected versions
75 explicit affected versions
91 explicit affected versions
79 explicit affected versions
70 explicit affected versions
10 explicit affected versions
30 explicit affected versions
26 explicit affected versions
82 explicit affected versions
7 explicit affected versions
77 explicit affected versions
34 explicit affected versions
13 explicit affected versions
85 explicit affected versions
37 explicit affected versions
35 explicit affected versions
42 explicit affected versions
40 explicit affected versions
18 explicit affected versions
35 explicit affected versions
118 explicit affected versions
64 explicit affected versions
39 explicit affected versions
120 explicit affected versions
13 explicit affected versions
4 explicit affected versions
23 explicit affected versions
45 explicit affected versions
124 explicit affected versions
1 explicit affected versions
1 explicit affected versions
21 explicit affected versions
9 explicit affected versions
16 explicit affected versions
10 explicit affected versions
13 explicit affected versions
76 explicit affected versions
41 explicit affected versions
8 explicit affected versions
7 explicit affected versions
12 explicit affected versions
11 explicit affected versions
111 explicit affected versions
7 explicit affected versions
12 explicit affected versions
14 explicit affected versions
10 explicit affected versions
1 explicit affected versions
7 explicit affected versions
9 explicit affected versions
104 explicit affected versions
12 explicit affected versions
2 explicit affected versions
105 explicit affected versions
12 explicit affected versions
34 explicit affected versions
36 explicit affected versions
16 explicit affected versions
10 explicit affected versions
23 explicit affected versions
27 explicit affected versions
10 explicit affected versions
37 explicit affected versions
10 explicit affected versions
2 explicit affected versions
13 explicit affected versions
33 explicit affected versions
3 explicit affected versions
10 explicit affected versions
11 explicit affected versions
57 explicit affected versions
1 explicit affected versions
26 explicit affected versions
5 explicit affected versions
13 explicit affected versions
29 explicit affected versions
1 explicit affected versions
29 explicit affected versions
111 explicit affected versions
13 explicit affected versions
12 explicit affected versions
87 explicit affected versions
34 explicit affected versions
34 explicit affected versions
1 explicit affected versions
1 explicit affected versions
100 explicit affected versions
82 explicit affected versions
45 explicit affected versions
33 explicit affected versions
23 explicit affected versions
51 explicit affected versions
10 explicit affected versions
13 explicit affected versions
12 explicit affected versions
11 explicit affected versions
5 explicit affected versions
12 explicit affected versions
2 explicit affected versions
7 explicit affected versions
12 explicit affected versions
1 explicit affected versions
9 explicit affected versions
138 explicit affected versions
5 explicit affected versions
67 explicit affected versions
132 explicit affected versions
83 explicit affected versions
154 explicit affected versions
10 explicit affected versions
26 explicit affected versions
32 explicit affected versions
1 explicit affected versions
59 explicit affected versions
28 explicit affected versions
40 explicit affected versions
11 explicit affected versions
2 explicit affected versions
13 explicit affected versions
39 explicit affected versions
139 explicit affected versions
78 explicit affected versions
16 explicit affected versions
81 explicit affected versions
43 explicit affected versions
116 explicit affected versions
3 explicit affected versions
132 explicit affected versions
93 explicit affected versions
1 explicit affected versions
7 explicit affected versions
2 explicit affected versions
8 explicit affected versions
51 explicit affected versions
9 explicit affected versions
92 explicit affected versions
18 explicit affected versions
35 explicit affected versions
12 explicit affected versions
66 explicit affected versions
70 explicit affected versions
3 explicit affected versions
27 explicit affected versions
56 explicit affected versions
121 explicit affected versions
1 explicit affected versions
1 explicit affected versions
98 explicit affected versions
36 explicit affected versions
8 explicit affected versions
47 explicit affected versions
5 explicit affected versions
8 explicit affected versions
1 explicit affected versions
03 / CONNECTIONS
Connected vulnerabilities
04 / EVIDENCE
Source records
In the Linux kernel, the following vulnerability has been resolved: net: openvswitch: remove never-working support for setting nsh fields The validation of the set(nsh(...)) action is completely wrong. It runs through the nsh_key_put_from_nlattr() function that is the same function that validates NSH keys for the flow match and the push_nsh() action. However, the set(nsh(...)) has a very different memory layout. Nested attributes in there are doubled in size in case of the masked set(). That makes proper validation impossible. There is also confusion in the code between the 'masked' flag, that says that the nested attributes are doubled in size containing both the value and the mask, and the 'is_mask' that says that the value we're parsing is the mask. This is causing kernel crash on trying to write into mask part of the match with SW_FLOW_KEY_PUT() during validation, while validate_nsh() doesn't allocate any memory for it: BUG: kernel NULL pointer dereference, address: 0000000000000018 #PF: supervisor read access in kernel mode #PF: error_code(0x0000) - not-present page PGD 1c2383067 P4D 1c2383067 PUD 20b703067 PMD 0 Oops: Oops: 0000 [#1] SMP NOPTI CPU: 8 UID: 0 Kdump: loaded Not tainted 6.17.0-rc4+ #107 PREEMPT(voluntary) RIP: 0010:nsh_key_put_from_nlattr+0x19d/0x610 [openvswitch] Call Trace: <TASK> validate_nsh+0x60/0x90 [openvswitch] validate_set.constprop.0+0x270/0x3c0 [openvswitch] __ovs_nla_copy_actions+0x477/0x860 [openvswitch] ovs_nla_copy_actions+0x8d/0x100 [openvswitch] ovs_packet_cmd_execute+0x1cc/0x310 [openvswitch] genl_family_rcv_msg_doit+0xdb/0x130 genl_family_rcv_msg+0x14b/0x220 genl_rcv_msg+0x47/0xa0 netlink_rcv_skb+0x53/0x100 genl_rcv+0x24/0x40 netlink_unicast+0x280/0x3b0 netlink_sendmsg+0x1f7/0x430 ____sys_sendmsg+0x36b/0x3a0 ___sys_sendmsg+0x87/0xd0 __sys_sendmsg+0x6d/0xd0 do_syscall_64+0x7b/0x2c0 entry_SYSCALL_64_after_hwframe+0x76/0x7e The third issue with this process is that while trying to convert the non-masked set into masked one, validate_set() copies and doubles the size of the OVS_KEY_ATTR_NSH as if it didn't have any nested attributes. It should be copying each nested attribute and doubling them in size independently. And the process must be properly reversed during the conversion back from masked to a non-masked variant during the flow dump. In the end, the only two outcomes of trying to use this action are either validation failure or a kernel crash. And if somehow someone manages to install a flow with such an action, it will most definitely not do what it is supposed to, since all the keys and the masks are mixed up. Fixing all the issues is a complex task as it requires re-writing most of the validation code. Given that and the fact that this functionality never worked since introduction, let's just remove it altogether. It's better to re-introduce it later with a proper implementation instead of trying to fix it in stable releases.
05 / REFERENCES
Further evidence
- https://git.kernel.org/linus/dfe28c4167a9259fc0c372d9f9473e1ac95cff67
- https://git.kernel.org/stable/c/0b903f33c31c82b1c3591279fd8a23893802b987
- https://git.kernel.org/stable/c/3415faa1fcb4150f29a72c5ecf959339d797feb7
- https://git.kernel.org/stable/c/4689ba45296dbb3a47e70a1bc2ed0328263e48f3
- https://git.kernel.org/stable/c/9c61d8fe1350b7322f4953318165d6719c3b1475
- https://git.kernel.org/stable/c/dfe28c4167a9259fc0c372d9f9473e1ac95cff67
- https://ubuntu.com/security/CVE-2025-40254
- https://ubuntu.com/security/notices/USN-8094-1
- https://ubuntu.com/security/notices/USN-8094-2
- https://ubuntu.com/security/notices/USN-8094-3
- https://ubuntu.com/security/notices/USN-8094-4
- https://ubuntu.com/security/notices/USN-8094-5
- https://ubuntu.com/security/notices/USN-8095-1
- https://ubuntu.com/security/notices/USN-8095-2
- https://ubuntu.com/security/notices/USN-8095-3
- https://ubuntu.com/security/notices/USN-8095-4
- https://ubuntu.com/security/notices/USN-8095-5
- https://ubuntu.com/security/notices/USN-8096-1
- https://ubuntu.com/security/notices/USN-8096-2
- https://ubuntu.com/security/notices/USN-8096-3
- https://ubuntu.com/security/notices/USN-8096-4
- https://ubuntu.com/security/notices/USN-8096-5
- https://ubuntu.com/security/notices/USN-8100-1
- https://ubuntu.com/security/notices/USN-8116-1
- https://ubuntu.com/security/notices/USN-8125-1
- https://ubuntu.com/security/notices/USN-8126-1
- https://ubuntu.com/security/notices/USN-8141-1
- https://ubuntu.com/security/notices/USN-8152-1
- https://ubuntu.com/security/notices/USN-8163-1
- https://ubuntu.com/security/notices/USN-8163-2
- https://ubuntu.com/security/notices/USN-8165-1
- https://ubuntu.com/security/notices/USN-8243-1
- https://ubuntu.com/security/notices/USN-8261-1
- https://www.cve.org/CVERecord?id=CVE-2025-40254